Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3193)

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 668193002: Remove isolate pointer from context objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32_test.cc ('k') | runtime/vm/stub_code_mips_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_mips.cc
===================================================================
--- runtime/vm/stub_code_mips.cc (revision 41244)
+++ runtime/vm/stub_code_mips.cc (working copy)
@@ -48,8 +48,7 @@
__ sw(FP, Address(SP, 0 * kWordSize));
__ mov(FP, SP);
- // Load current Isolate pointer from Context structure into A0.
- __ lw(A0, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(A0);
// Save exit frame information to enable stack walking as we are about
// to transition to Dart VM C++ code.
@@ -174,8 +173,7 @@
__ sw(FP, Address(SP, 0 * kWordSize));
__ mov(FP, SP);
- // Load current Isolate pointer from Context structure into A0.
- __ lw(A0, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(A0);
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
@@ -289,8 +287,7 @@
__ sw(FP, Address(SP, 0 * kWordSize));
__ mov(FP, SP);
- // Load current Isolate pointer from Context structure into A0.
- __ lw(A0, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(A0);
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
@@ -1097,13 +1094,6 @@
// T1: number of context variables as integer value (not object).
__ sw(T1, FieldAddress(V0, Context::num_variables_offset()));
- // Setup isolate field.
- // V0: new object.
- // T1: number of context variables.
- // T2: isolate, not an object.
- __ LoadIsolate(T2);
- __ sw(T2, FieldAddress(V0, Context::isolate_offset()));
-
__ LoadImmediate(T7, reinterpret_cast<intptr_t>(Object::null()));
// Initialize the context variables.
@@ -1939,7 +1929,7 @@
void StubCode::GenerateDebugStepCheckStub(Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ lw(T0, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(T0);
__ lbu(T0, Address(T0, Isolate::single_step_offset()));
__ BranchNotEqual(T0, Immediate(0), &stepping);
__ Bind(&done_stepping);
@@ -2228,7 +2218,7 @@
Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
- __ lw(T0, FieldAddress(CTX, Context::isolate_offset()));
+ __ LoadIsolate(T0);
__ lbu(T0, Address(T0, Isolate::single_step_offset()));
__ BranchNotEqual(T0, Immediate(0), &stepping);
__ Bind(&done_stepping);
« no previous file with comments | « runtime/vm/stub_code_ia32_test.cc ('k') | runtime/vm/stub_code_mips_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698