Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 625413002: Remove special list behavior in analysis server protocol. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove special list behavior in analysis server protocol. Previously, for optional lists, the absence of a list was treated by the toJson and fromJson methods as equivalent to the presence of an empty list. This disagreed with the API documentation in several places and created the risk of null reference exceptions in clients. This change makes optional lists behave just like optional fields of any other type. BUG=dartbug.com/21230 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=40939

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-06 02:12:58 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-06 14:04:07 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-06 16:32:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698