pkg/analysis_server/lib/src/protocol.dart - Issue 625413002: Remove special list behavior in analysis server protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/protocol.dart

Issue 625413002: Remove special list behavior in analysis server protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/generated_protocol.dart ('k') | pkg/analysis_server/test/analysis/notification_overrides_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/protocol.dart

diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart

index 212c1a5bdd6b13a5a3a6ded90de45a49c3951ffd..196647465a43a6fefa179529fc354ea78e5e40f3 100644

--- a/pkg/analysis_server/lib/src/protocol.dart

+++ b/pkg/analysis_server/lib/src/protocol.dart

@@ -293,6 +293,12 @@ SourceFileEdit _getChangeFileEdit(SourceChange change, String file) {

* list elements.

bool _listEqual(List listA, List listB, bool itemEqual(a, b)) {

+ if (listA == null) {

+ return listB == null;

+ }

+ if (listB == null) {

+ return false;

+ }

if (listA.length != listB.length) {

return false;

}