pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart - Issue 625413002: Remove special list behavior in analysis server protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

Issue 625413002: Remove special list behavior in analysis server protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/integration/analysis/overrides_test.dart ('k') | pkg/analysis_server/test/search/type_hierarchy_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

diff --git a/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart b/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

index 1793c6f834268948effe3daf8323598e67c62cc8..7849b7592acf0916769feeaf3208565547d3a055 100644

--- a/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

+++ b/pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart

@@ -269,14 +269,6 @@ main /* target */ () {

offset)).then((result) {

if (result.hierarchyItems == null) {

return null;

- } else if (result.hierarchyItems.isEmpty) {

- // TODO(paulberry): As a result of bug 21230, a type hierarchy result

- // with no hierarchyItems field gets misinterpreted as a type hierarchy

- // result with a hierarchyItems which is an empty list. To work around

- // that, treat an empty hierarchyItems list as equivalent to

- // hierarchyItems being absent. Once bug 21230 is fixed we should

- // remove this.

- return null;

} else {

return new HierarchyResults(result.hierarchyItems);

}