pkg/analysis_server/test/integration/analysis/overrides_test.dart - Issue 625413002: Remove special list behavior in analysis server protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/analysis/overrides_test.dart

Issue 625413002: Remove special list behavior in analysis server protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/analysis/notification_overrides_test.dart ('k') | pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/analysis/overrides_test.dart

diff --git a/pkg/analysis_server/test/integration/analysis/overrides_test.dart b/pkg/analysis_server/test/integration/analysis/overrides_test.dart

index 400ea82b903a7b8092d21c292ffbeeab2b133524..9f5212fadf5ac8d81e2828957282c3ff353a1c18 100644

--- a/pkg/analysis_server/test/integration/analysis/overrides_test.dart

+++ b/pkg/analysis_server/test/integration/analysis/overrides_test.dart

@@ -101,11 +101,7 @@ class Target extends Base implements Interface1, Interface2 {

expect(actualOverridesInterfaces, equals(

expectedOverridesInterfaces.toSet()));

} else {

- // TODO(paulberry): As a result of bug 21230, an Override with a

- // missing interfaceMembers field is misinterpreted as having an

- // interfaceMembers field which is an empty list. Once bug 21230 is

- // fixed this should be an "isNull" check.

- expect(interfaceMembers, isEmpty);

+ expect(interfaceMembers, isNull);

}

checkOverrides('method0', true, ['Interface1', 'Interface2']);