Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: pkg/analysis_server/test/integration/analysis/overrides_test.dart

Issue 625413002: Remove special list behavior in analysis server protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.integration.analysis.overrides; 5 library test.integration.analysis.overrides;
6 6
7 import 'package:analysis_server/src/protocol.dart'; 7 import 'package:analysis_server/src/protocol.dart';
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 9
10 import '../../reflective_tests.dart'; 10 import '../../reflective_tests.dart';
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 Set<String> actualOverridesInterfaces = new Set<String>(); 94 Set<String> actualOverridesInterfaces = new Set<String>();
95 for (OverriddenMember overriddenMember in interfaceMembers) { 95 for (OverriddenMember overriddenMember in interfaceMembers) {
96 expect(overriddenMember.element.name, equals(methodName)); 96 expect(overriddenMember.element.name, equals(methodName));
97 String className = overriddenMember.className; 97 String className = overriddenMember.className;
98 bool wasAdded = actualOverridesInterfaces.add(className); 98 bool wasAdded = actualOverridesInterfaces.add(className);
99 expect(wasAdded, isTrue); 99 expect(wasAdded, isTrue);
100 } 100 }
101 expect(actualOverridesInterfaces, equals( 101 expect(actualOverridesInterfaces, equals(
102 expectedOverridesInterfaces.toSet())); 102 expectedOverridesInterfaces.toSet()));
103 } else { 103 } else {
104 // TODO(paulberry): As a result of bug 21230, an Override with a 104 expect(interfaceMembers, isNull);
105 // missing interfaceMembers field is misinterpreted as having an
106 // interfaceMembers field which is an empty list. Once bug 21230 is
107 // fixed this should be an "isNull" check.
108 expect(interfaceMembers, isEmpty);
109 } 105 }
110 } 106 }
111 checkOverrides('method0', true, ['Interface1', 'Interface2']); 107 checkOverrides('method0', true, ['Interface1', 'Interface2']);
112 checkOverrides('method1', false, ['Interface1', 'Interface2']); 108 checkOverrides('method1', false, ['Interface1', 'Interface2']);
113 checkOverrides('method2', true, ['Interface1']); 109 checkOverrides('method2', true, ['Interface1']);
114 checkOverrides('method3', false, ['Interface1']); 110 checkOverrides('method3', false, ['Interface1']);
115 checkOverrides('method4', true, ['Interface2']); 111 checkOverrides('method4', true, ['Interface2']);
116 checkOverrides('method5', false, ['Interface2']); 112 checkOverrides('method5', false, ['Interface2']);
117 checkOverrides('method6', true, []); 113 checkOverrides('method6', true, []);
118 checkOverrides('method7', false, []); 114 checkOverrides('method7', false, []);
119 }); 115 });
120 } 116 }
121 } 117 }
122 118
123 main() { 119 main() {
124 runReflectiveTests(Test); 120 runReflectiveTests(Test);
125 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698