Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje…

Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib

Add generic 'Object' ref and view element. This will work for any ServiceObject with type == 'Object'.

Ref element uses the vmType as the link text if there is no name.
View element is mostly just <object-common> but that allows calculating retaining path, retained size, etc.

BUG=
R=rmacnak@google.com, turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40119

[Cutch, 2014-09-09 18:48:21]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com, turnidge@google.com

[turnidge, 2014-09-09 19:30:25]

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/object_common.html
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/object_common.html:30: </div>
I wonder if these should move to some sort of "instance-view"

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:107: } else
if (ref.isObject) {
I think this could be a switch in the case statement instead.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart:161: } else
if (object.isObject) {
ditto other comment.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:84: bool get
isObject => type == 'Object';
Technically all responses are an Object, if you want to make this consistent
with the meaning of isInstance, above... for now you could use isPlainObject?

[rmacnak, 2014-09-09 20:36:31]

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/object_common.html
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/object_common.html:17:
<template if="{{ object.clazz != null }}">
An object should always have a class and size.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html:13: <a
on-click="{{ goto }}" _href="{{ url }}">{{ ref.vmType }}</a>
<em>{{ ref.vmType }}</em> ?

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html:16: <a
on-click="{{ goto }}" _href="{{ url }}">{{ name }}</a>
Ditto

[Cutch, 2014-09-10 19:59:20]

PTAL

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/object_common.html
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/object_common.html:17:
<template if="{{ object.clazz != null }}">
On 2014/09/09 20:36:31, rmacnak wrote:
> An object should always have a class and size.

Acknowledged.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/object_common.html:30: </div>
On 2014/09/09 19:30:24, turnidge wrote:
> I wonder if these should move to some sort of "instance-view"

Acknowledged.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:107: } else
if (ref.isObject) {
On 2014/09/09 19:30:25, turnidge wrote:
> I think this could be a switch in the case statement instead.

Done.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html:13: <a
on-click="{{ goto }}" _href="{{ url }}">{{ ref.vmType }}</a>
On 2014/09/09 20:36:31, rmacnak wrote:
> <em>{{ ref.vmType }}</em> ?

Done.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.html:16: <a
on-click="{{ goto }}" _href="{{ url }}">{{ name }}</a>
On 2014/09/09 20:36:31, rmacnak wrote:
> Ditto

Done.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart
(right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart:161: } else
if (object.isObject) {
On 2014/09/09 19:30:25, turnidge wrote:
> ditto other comment.

Done.

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/560503002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:84: bool get
isObject => type == 'Object';
On 2014/09/09 19:30:25, turnidge wrote:
> Technically all responses are an Object, if you want to make this consistent
> with the meaning of isInstance, above... for now you could use isPlainObject?

I don't need this anymore- killing.

[rmacnak, 2014-09-10 21:10:12]

LGTM

[turnidge, 2014-09-10 21:16:43]

lgtm

[Cutch, 2014-09-10 21:21:25]

Committed patchset #3 (id:40001) manually as 40119 (presubmit successful).