Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
index 3637bbd2680a69538e8a1626d0f4a1e0c9a64c63..63f24499eaa9b7b64a75b9b528bd53f76a88e6c9 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
@@ -53,7 +53,7 @@ class ServiceRefElement extends ObservatoryElement {
// Workaround isEmpty not being useable due to missing @MirrorsUsed.
bool get nameIsEmpty {
- return name.isEmpty;
+ return (name == null) || name.isEmpty;
}
}
@@ -94,6 +94,14 @@ class AnyServiceRefElement extends ObservatoryElement {
ServiceRefElement element = new Element.tag('library-ref');
element.ref = ref;
return element;
+ case 'Object':
+ ServiceRefElement element = new Element.tag('object-ref');
+ element.ref = ref;
+ return element;
+ case 'Script':
+ ServiceRefElement element = new Element.tag('script-ref');
+ element.ref = ref;
+ return element;
default:
if (ref.isInstance ||
ref.isSentinel) { // TODO(rmacnak): Separate this out.
@@ -125,3 +133,8 @@ class AnyServiceRefElement extends ObservatoryElement {
Logger.root.info('Viewing object of \'${type}\'');
}
}
+
+@CustomTag('object-ref')
+class ObjectRefElement extends ServiceRefElement {
+ ObjectRefElement.created() : super.created();
+}

Powered by Google App Engine
This is Rietveld 408576698