runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart - Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart

Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/context_ref.dart ('k') | runtime/bin/vmservice/observatory/lib/src/elements/object_common.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart b/runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart

index b1814e4acca48805e6681d9db0d53bdb864ef009..6079530b3bdb7cf7a577ff4f2dfc94616b5944d5 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart

@@ -21,8 +21,8 @@ class ObjectCommonElement extends ObservatoryElement {

// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".

Future<ServiceObject> retainedSize(var dummy) {

return object.isolate.get(object.id + "/retained")

- .then((ServiceMap obj) {

- retainedBytes = int.parse(obj['valueAsString']);

+ .then((Instance obj) {

+ retainedBytes = int.parse(obj.valueAsString);

});

}