Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje…

runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library service_ref_element;
 
 import 'dart:html';
 import 'package:logging/logging.dart';
 import 'package:polymer/polymer.dart';
 import 'observatory_element.dart';
@@ skipping 35 matching lines @@
 
   String get name {
     if (ref == null) {
       return 'NULL REF';
     }
     return ref.name;
   }
 
   // Workaround isEmpty not being useable due to missing @MirrorsUsed.
   bool get nameIsEmpty {
-    return name.isEmpty;
+    return (name == null) || name.isEmpty;
   }
 }
 
 
 @CustomTag('any-service-ref')
 class AnyServiceRefElement extends ObservatoryElement {
   @published ServiceObject ref;
   AnyServiceRefElement.created() : super.created();
 
   Element _constructElementForRef() {
@@ skipping 20 matching lines @@
         element.ref = ref;
         return element;
       case 'Function':
         ServiceRefElement element = new Element.tag('function-ref');
         element.ref = ref;
         return element;
       case 'Library':
         ServiceRefElement element = new Element.tag('library-ref');
         element.ref = ref;
         return element;
+      case 'Script':
+        ServiceRefElement element = new Element.tag('script-ref');
+        element.ref = ref;
+        return element;
       default:
         if (ref.isInstance ||
             ref.isSentinel) {  // TODO(rmacnak): Separate this out.
           ServiceRefElement element = new Element.tag('instance-ref');
           element.ref = ref;
           return element;
+        } else if (ref.isObject) {

[turnidge, 2014/09/09 19:30:25]

I think this could be a switch in the case statement instead.

[Cutch, 2014/09/10 19:59:20]

Done.

+          ServiceRefElement element = new Element.tag('object-ref');
+          element.ref = ref;
+          return element;
         } else {
           SpanElement element = new Element.tag('span');
           element.text = "<<Unknown service ref: $ref>>";
           return element;
         }
     }
   }
 
   refChanged(oldValue) {
     // Remove the current view.
     children.clear();
     if (ref == null) {
       Logger.root.info('Viewing null object.');
       return;
     }
     var type = ref.vmType;
     var element = _constructElementForRef();
     if (element == null) {
       Logger.root.info('Unable to find a ref element for \'${type}\'');
       return;
     }
     children.add(element);
     Logger.root.info('Viewing object of \'${type}\'');
   }
 }
+
+@CustomTag('object-ref')
+class ObjectRefElement extends ServiceRefElement {
+  ObjectRefElement.created() : super.created();
+}