Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library service_object_view_element; 5 library service_object_view_element;
6 6
7 import 'dart:html'; 7 import 'dart:html';
8 import 'package:logging/logging.dart'; 8 import 'package:logging/logging.dart';
9 import 'package:observatory/service.dart'; 9 import 'package:observatory/service.dart';
10 import 'package:observatory/tracer.dart'; 10 import 'package:observatory/tracer.dart';
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 case 'VM': 151 case 'VM':
152 VMViewElement element = new Element.tag('vm-view'); 152 VMViewElement element = new Element.tag('vm-view');
153 element.vm = object; 153 element.vm = object;
154 return element; 154 return element;
155 default: 155 default:
156 if (object.isInstance || 156 if (object.isInstance ||
157 object.isSentinel) { // TODO(rmacnak): Separate this out. 157 object.isSentinel) { // TODO(rmacnak): Separate this out.
158 InstanceViewElement element = new Element.tag('instance-view'); 158 InstanceViewElement element = new Element.tag('instance-view');
159 element.instance = object; 159 element.instance = object;
160 return element; 160 return element;
161 } else if (object.isObject) {
turnidge 2014/09/09 19:30:25 ditto other comment.
Cutch 2014/09/10 19:59:20 Done.
162 ObjectViewElement element = new Element.tag('object-view');
163 element.object = object;
164 return element;
161 } else { 165 } else {
162 JsonViewElement element = new Element.tag('json-view'); 166 JsonViewElement element = new Element.tag('json-view');
163 element.map = object; 167 element.map = object;
164 return element; 168 return element;
165 } 169 }
166 } 170 }
167 } 171 }
168 172
169 objectChanged(oldValue) { 173 objectChanged(oldValue) {
170 // Remove the current view. 174 // Remove the current view.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 234
231 dynamic expander() { 235 dynamic expander() {
232 return expandEvent; 236 return expandEvent;
233 } 237 }
234 238
235 void expandEvent(bool exp, var done) { 239 void expandEvent(bool exp, var done) {
236 expand = exp; 240 expand = exp;
237 done(); 241 done();
238 } 242 }
239 } 243 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698