Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 538253002: Use primitive int/boolean where possible in the Java client. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1, lukeechurch_gmail.com
Visibility:
Public.

Description

Use primitive int/boolean where possible in the Java client. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -295 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 8 chunks +8 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java View 2 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisStatus.java View 4 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java View 8 chunks +17 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableFeedback.java View 5 chunks +9 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableOptions.java View 3 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodFeedback.java View 11 chunks +19 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java View 5 chunks +9 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FoldingRegion.java View 3 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HighlightRegion.java View 3 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HoverInformation.java View 5 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/InlineMethodOptions.java View 4 chunks +9 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditGroup.java View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Location.java View 3 chunks +13 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/NavigationRegion.java View 4 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Occurrences.java View 4 chunks +8 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java View 4 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverrideMember.java View 4 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Position.java View 3 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java View 3 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceEdit.java View 4 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/TypeHierarchyItem.java View 7 chunks +14 lines, -14 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 7 chunks +9 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/utilities/general/JsonUtilities.java View 1 chunk +14 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 5 chunks +9 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 16 chunks +57 lines, -57 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java View 1 chunk +2 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/MarkOccurrencesManager_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 4 chunks +21 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 7 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-04 23:17:35 UTC) #1
jwren
On 2014/09/04 23:17:35, scheglov wrote: LGTM
6 years, 3 months ago (2014-09-04 23:35:15 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-04 23:53:34 UTC) #3
scheglov
6 years, 3 months ago (2014-09-05 00:17:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 39891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698