Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

Issue 538253002: Use primitive int/boolean where possible in the Java client. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java
index c414d726ac79957aa388f8641e7ac97c72f00a27..34fda264f510f611fc1e5f3316fab70eef695376 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java
@@ -261,7 +261,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
// }
@Override
- public void analysis_getHover(String file, Integer offset, GetHoverConsumer consumer) {
+ public void analysis_getHover(String file, int offset, GetHoverConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(id, RequestUtilities.generateAnalysisGetHover(id, file, offset), consumer);
}
@@ -327,7 +327,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
}
@Override
- public void completion_getSuggestions(String file, Integer offset, GetSuggestionsConsumer consumer) {
+ public void completion_getSuggestions(String file, int offset, GetSuggestionsConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(
id,
@@ -356,8 +356,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
}
@Override
- public void edit_getAssists(String file, Integer offset, Integer length,
- GetAssistsConsumer consumer) {
+ public void edit_getAssists(String file, int offset, int length, GetAssistsConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(
id,
@@ -366,7 +365,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
}
@Override
- public void edit_getAvailableRefactorings(String file, Integer offset, Integer length,
+ public void edit_getAvailableRefactorings(String file, int offset, int length,
GetAvailableRefactoringsConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(
@@ -376,14 +375,14 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
}
@Override
- public void edit_getFixes(String file, Integer offset, GetFixesConsumer consumer) {
+ public void edit_getFixes(String file, int offset, GetFixesConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(id, RequestUtilities.generateEditGetFixes(id, file, offset), consumer);
}
@Override
- public void edit_getRefactoring(String kindId, String file, Integer offset, Integer length,
- Boolean validateOnly, RefactoringOptions options, GetRefactoringConsumer consumer) {
+ public void edit_getRefactoring(String kindId, String file, int offset, int length,
+ boolean validateOnly, RefactoringOptions options, GetRefactoringConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(id, RequestUtilities.generateEditGetRefactoring(
id,
@@ -467,7 +466,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
//}
@Override
- public void search_findElementReferences(String file, Integer offset, Boolean includePotential,
+ public void search_findElementReferences(String file, int offset, boolean includePotential,
FindElementReferencesConsumer consumer) {
// TODO (jwren) re-implement
}
@@ -489,7 +488,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {
}
@Override
- public void search_getTypeHierarchy(String file, Integer offset, GetTypeHierarchyConsumer consumer) {
+ public void search_getTypeHierarchy(String file, int offset, GetTypeHierarchyConsumer consumer) {
String id = generateUniqueId();
sendRequestToServer(
id,

Powered by Google App Engine
This is Rietveld 408576698