Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java

Issue 538253002: Use primitive int/boolean where possible in the Java client. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java
index 6a9b332f8f887d59b396d717fa0c5784d344123f..c45b022260606fcd3dbfec4777f1719a675271ea 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java
@@ -50,7 +50,7 @@ public class ExtractMethodOptions extends RefactoringOptions {
* True if a getter should be created rather than a method. It is an error if this field is true
* and the list of parameters is non-empty.
*/
- private final Boolean createGetter;
+ private final boolean createGetter;
/**
* The name that the method should be given.
@@ -75,12 +75,12 @@ public class ExtractMethodOptions extends RefactoringOptions {
* the method. The expression or statements used to initiate the refactoring will always be
* replaced.
*/
- private final Boolean extractAll;
+ private final boolean extractAll;
/**
* Constructor for {@link ExtractMethodOptions}.
*/
- public ExtractMethodOptions(String returnType, Boolean createGetter, String name, List<RefactoringMethodParameter> parameters, Boolean extractAll) {
+ public ExtractMethodOptions(String returnType, boolean createGetter, String name, List<RefactoringMethodParameter> parameters, boolean extractAll) {
this.returnType = returnType;
this.createGetter = createGetter;
this.name = name;
@@ -94,20 +94,20 @@ public class ExtractMethodOptions extends RefactoringOptions {
ExtractMethodOptions other = (ExtractMethodOptions) obj;
return
ObjectUtilities.equals(other.returnType, returnType) &&
- ObjectUtilities.equals(other.createGetter, createGetter) &&
+ other.createGetter == createGetter &&
ObjectUtilities.equals(other.name, name) &&
ObjectUtilities.equals(other.parameters, parameters) &&
- ObjectUtilities.equals(other.extractAll, extractAll);
+ other.extractAll == extractAll;
}
return false;
}
public static ExtractMethodOptions fromJson(JsonObject jsonObject) {
String returnType = jsonObject.get("returnType").getAsString();
- Boolean createGetter = jsonObject.get("createGetter").getAsBoolean();
+ boolean createGetter = jsonObject.get("createGetter").getAsBoolean();
String name = jsonObject.get("name").getAsString();
List<RefactoringMethodParameter> parameters = RefactoringMethodParameter.fromJsonArray(jsonObject.get("parameters").getAsJsonArray());
- Boolean extractAll = jsonObject.get("extractAll").getAsBoolean();
+ boolean extractAll = jsonObject.get("extractAll").getAsBoolean();
return new ExtractMethodOptions(returnType, createGetter, name, parameters, extractAll);
}
@@ -127,7 +127,7 @@ public class ExtractMethodOptions extends RefactoringOptions {
* True if a getter should be created rather than a method. It is an error if this field is true
* and the list of parameters is non-empty.
*/
- public Boolean createGetter() {
+ public boolean createGetter() {
return createGetter;
}
@@ -136,7 +136,7 @@ public class ExtractMethodOptions extends RefactoringOptions {
* the method. The expression or statements used to initiate the refactoring will always be
* replaced.
*/
- public Boolean extractAll() {
+ public boolean extractAll() {
return extractAll;
}

Powered by Google App Engine
This is Rietveld 408576698