Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java

Issue 538253002: Use primitive int/boolean where possible in the Java client. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java
index 12a75fea314245634a7bd0c5910085464d67d0ba..fcf437acc07078c10f50ff7ecdbb03e22cce34e7 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java
@@ -58,7 +58,7 @@ public class SearchResult {
* all references to a method m defined in some class were requested, and a reference to a method m
* from an unknown class were found, it would be marked as being a potential match.
*/
- private final Boolean isPotential;
+ private final boolean isPotential;
/**
* The elements that contain the result, starting with the most immediately enclosing ancestor and
@@ -69,7 +69,7 @@ public class SearchResult {
/**
* Constructor for {@link SearchResult}.
*/
- public SearchResult(Location location, String kind, Boolean isPotential, List<Element> path) {
+ public SearchResult(Location location, String kind, boolean isPotential, List<Element> path) {
this.location = location;
this.kind = kind;
this.isPotential = isPotential;
@@ -83,7 +83,7 @@ public class SearchResult {
return
ObjectUtilities.equals(other.location, location) &&
ObjectUtilities.equals(other.kind, kind) &&
- ObjectUtilities.equals(other.isPotential, isPotential) &&
+ other.isPotential == isPotential &&
ObjectUtilities.equals(other.path, path);
}
return false;
@@ -92,7 +92,7 @@ public class SearchResult {
public static SearchResult fromJson(JsonObject jsonObject) {
Location location = Location.fromJson(jsonObject.get("location").getAsJsonObject());
String kind = jsonObject.get("kind").getAsString();
- Boolean isPotential = jsonObject.get("isPotential").getAsBoolean();
+ boolean isPotential = jsonObject.get("isPotential").getAsBoolean();
List<Element> path = Element.fromJsonArray(jsonObject.get("path").getAsJsonArray());
return new SearchResult(location, kind, isPotential, path);
}
@@ -114,7 +114,7 @@ public class SearchResult {
* all references to a method m defined in some class were requested, and a reference to a method m
* from an unknown class were found, it would be marked as being a potential match.
*/
- public Boolean isPotential() {
+ public boolean isPotential() {
return isPotential;
}

Powered by Google App Engine
This is Rietveld 408576698