editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java - Issue 538253002: Use primitive int/boolean where possible in the Java client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java

Issue 538253002: Use primitive int/boolean where possible in the Java client. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/MarkOccurrencesManager_NEW.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java

index 16e24b9bebbf55e267a8aaa9a1f732eb89f4cbe0..d773087d1ca905afefdd19970884436067123c4c 100644

--- a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java

+++ b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartCompletionReceiverTest.java

@@ -39,10 +39,9 @@ public class DartCompletionReceiverTest extends TestCase {

}

@Override

- public void completion_getSuggestions(String file, Integer offset,

- GetSuggestionsConsumer consumer) {

+ public void completion_getSuggestions(String file, int offset, GetSuggestionsConsumer consumer) {

assertEquals(testFile, file);

- assertEquals(testOffset, offset.intValue());

+ assertEquals(testOffset, offset);

this.consumer = consumer;

// Send results asynchronously

Thread thread = new Thread(getClass().getSimpleName() + " suggestion results") {