|
|
Allow observatory to distinguish between user-level and vm-level types.
Currently the 'type' property always encodes a vm-specific type. In
the future 'type' will specify a user-level (Dart-ish) type and
'vmType' will (optionally) specify a vm-specific type if it is
different. This will allow an application like a debugger (for
example) to ignore the specifics of the vm-internal Instance hierarchy
while still providing this information for applications like
Observatory, which want to know everything.
So, in this change, we prepare Observatory to receive both 'type' and
'vmType' properties.
Specifics:
- replace 'serviceType' on ServiceObject with 'type' and 'vmType'.
- replace uses of serviceType with type or vmType as appropriate.
- fix a couple of stray bugs I found ('user_name', etc.)
BUG=
R=johnmccutchan@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39705
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+161 lines, -150 lines) |
Patch |
 |
M |
runtime/bin/vmservice/observatory/deployed/web/index.html
|
View
|
1
|
6 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
|
View
|
1
|
6 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html
|
View
|
1
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/io_view.html
|
View
|
1
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js
|
View
|
1
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log
|
View
|
1
|
1 chunk |
+16 lines, -13 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log
|
View
|
1
|
1 chunk |
+31 lines, -22 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js
|
View
|
1
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/field_view.html
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/io_view.html
|
View
|
1
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/isolate_profile.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart
|
View
|
|
2 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/lib/src/service/object.dart
|
View
|
1
|
12 chunks |
+32 lines, -28 lines |
0 comments
|
Download
|
 |
M |
runtime/bin/vmservice/observatory/test/vm_metrics_test.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|