runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart - Issue 515303005: Allow observatory to distinguish between user-level and vm-level types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart

Issue 515303005: Allow observatory to distinguish between user-level and vm-level types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/field_view.html ('k') | runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart

index 4fddfbb5a3c2ca74357e13223b7aded1be8e112a..96bd2333691f483ba5cffe579f0b804adb528eeb 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart

@@ -14,7 +14,7 @@ class InstanceRefElement extends ServiceRefElement {

String get hoverText {

if (ref != null) {

- if (ref.serviceType == 'Null') {

+ if (ref.type == 'Sentinel') {

if (ref.id == 'objects/optimized-out') {

return 'This object is no longer needed and has been removed by the optimizing compiler.';

} else if (ref.id == 'objects/collected') {