runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart - Issue 515303005: Allow observatory to distinguish between user-level and vm-level types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart

Issue 515303005: Allow observatory to distinguish between user-level and vm-level types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/isolate_profile.dart ('k') | runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart b/runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart

index a1ab9cacef1903877da72570cd3931a78f382cc6..46478f428ae09a6fa2ee59c3e4dcbe75754d3533 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/isolate_view.dart

@@ -134,7 +134,7 @@ class IsolateViewElement extends ObservatoryElement {

return isolate.get("debug/pause").then((result) {

// TODO(turnidge): Instead of asserting here, handle errors

// properly.

- assert(result.serviceType == 'Success');

+ assert(result.type == 'Success');

return isolate.reload();

});

}

@@ -143,7 +143,7 @@ class IsolateViewElement extends ObservatoryElement {

return isolate.get("resume").then((result) {

// TODO(turnidge): Instead of asserting here, handle errors

// properly.

- assert(result.serviceType == 'Success');

+ assert(result.type == 'Success');

return isolate.reload();

});

}