runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart - Issue 515303005: Allow observatory to distinguish between user-level and vm-level types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

Issue 515303005: Allow observatory to distinguish between user-level and vm-level types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart ('k') | runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

index 466799dfe8f68f53ee6171e8b9a6b7fa0aa7e217..e02ecae1b35307c9e80750465c8457b5f354cf15 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

@@ -64,7 +64,7 @@ class AnyServiceRefElement extends ObservatoryElement {

AnyServiceRefElement.created() : super.created();

Element _constructElementForRef() {

- var type = ref.serviceType;

+ var type = ref.vmType;

switch (type) {

case 'Class':

ServiceRefElement element = new Element.tag('class-ref');

@@ -115,7 +115,7 @@ class AnyServiceRefElement extends ObservatoryElement {

Logger.root.info('Viewing null object.');

return;

}

- var type = ref.serviceType;

+ var type = ref.vmType;

var element = _constructElementForRef();

if (element == null) {

Logger.root.info('Unable to find a ref element for \'${type}\'');