runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html - Issue 515303005: Allow observatory to distinguish between user-level and vm-level types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html

Issue 515303005: Allow observatory to distinguish between user-level and vm-level types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/index_devtools.html ('k') | runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html

diff --git a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html

index c785aaadea13fecf5bb08813d870a055006348bc..1ef9c7c265c03e8a7133dbcbfd2e7fc785fdab88 100644

--- a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html

+++ b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html

@@ -12,11 +12,11 @@

<nav-bar>

<top-nav-menu></top-nav-menu>

<isolate-nav-menu isolate="{{ field.isolate }}"></isolate-nav-menu>

- <template if="{{ field['owner'].serviceType == 'Class' }}">

+ <template if="{{ field['owner'].type == 'Class' }}">

<class-nav-menu cls="{{ field['owner'] }}"></class-nav-menu>

</template>

- <template if="{{ field['owner'].serviceType == 'Library' }}">

+ <template if="{{ field['owner'].type == 'Library' }}">

<library-nav-menu library="{{ field['owner'] }}"></library-nav-menu>

</template>

<nav-menu link="{{ field.link }}" anchor="{{ field.name }}" last="{{ true }}"></nav-menu>

@@ -42,10 +42,10 @@

<div class="memberName">owner</div>

- <template if="{{ field['owner'].serviceType == 'Class' }}">

+ <template if="{{ field['owner'].type == 'Class' }}">

<class-ref ref="{{ field['owner'] }}"></class-ref>

</template>

- <template if="{{ field['owner'].serviceType != 'Class' }}">

+ <template if="{{ field['owner'].type != 'Class' }}">

<library-ref ref="{{ field['owner'] }}"></library-ref>

</template>

</div>