Issue 492483002: Change analysis.updateOptions to use generated classes.

Issue 492483002: Change analysis.updateOptions to use generated classes. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change analysis.updateOptions to use generated classes. Note that there is a small change in behavior: unrecognized options are now silently ignored; they no longer generate an error. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39380

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -75 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	4 chunks	+43 lines, -47 lines	2 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	2 chunks	+18 lines, -17 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/492483002/diff/1/pkg/analysis_server/lib/src/domain_analysis.dart File pkg/analysis_server/lib/src/domain_analysis.dart (right): https://codereview.chromium.org/492483002/diff/1/pkg/analysis_server/lib/src/domain_analysis.dart#newcode211 pkg/analysis_server/lib/src/domain_analysis.dart:211: // TODO(brianwilkerson) Uncomment this when the option is ...

6 years, 4 months ago (2014-08-19 19:50:18 UTC) #2

Paul Berry

Committed patchset #1 manually as 39380 (presubmit successful).

6 years, 4 months ago (2014-08-19 19:57:49 UTC) #3

Paul Berry

6 years, 4 months ago (2014-08-19 19:58:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/492483002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_analysis.dart (right):

https://codereview.chromium.org/492483002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_analysis.dart:211: // TODO(brianwilkerson)
Uncomment this when the option is supported.
On 2014/08/19 19:50:17, Brian Wilkerson wrote:
> The enableAsync and enableEnum options should be supported now. (Not that it
> needs to be changed for this CL.)

Ok.  I went ahead and uncommented the code.

Expand Messages | Collapse Messages