Change analysis.updateOptions to use generated classes.

pkg/analysis_server/lib/src/domain_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.analysis;
 
 import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_hover.dart';
 import 'package:analysis_server/src/computer/error.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/protocol2.dart';
 import 'package:analysis_server/src/services/correction/change.dart';
 import 'package:analyzer/src/generated/ast.dart';
-import 'package:analyzer/src/generated/engine.dart';
+import 'package:analyzer/src/generated/engine.dart' as engine;
 
 
 /**
  * Instances of the class [AnalysisDomainHandler] implement a [RequestHandler]
  * that handles requests in the `analysis` domain.
  */
 class AnalysisDomainHandler implements RequestHandler {
   /**
    * The analysis server that is using this handler to process requests.
    */
   final AnalysisServer server;
 
   /**
    * Initialize a newly created handler to handle requests for the given [server].
    */
   AnalysisDomainHandler(this.server);
 
   /**
    * Implement the `analysis.getErrors` request.
    */
   Response getErrors(Request request) {
     String file = new AnalysisGetErrorsParams.fromRequest(request).file;
     server.onFileAnalysisComplete(file).then((_) {
       Response response = new Response(request.id);
-      AnalysisErrorInfo errorInfo = server.getErrors(file);
+      engine.AnalysisErrorInfo errorInfo = server.getErrors(file);
       if (errorInfo == null) {
         response.setResult(ERRORS, []);
       } else {
         response.setResult(ERRORS, engineErrorInfoToJson(errorInfo));
       }
       server.sendResponse(response);
     }).catchError((message) {
       if (message is! String) {
-        AnalysisEngine.instance.logger.logError(
+        engine.AnalysisEngine.instance.logger.logError(
             'Illegal error message during getErrors: $message');
         message = '';
       }
       Response response = new Response.getErrorsError(request, message);
       response.setResult(ERRORS, []);
       server.sendResponse(response);
     });
     // delay response
     return Response.DELAYED_RESPONSE;
   }
@@ skipping 124 matching lines @@
     }
     server.updateContent(changes);
     return new Response(request.id);
   }
 
   /**
    * Implement the 'analysis.updateOptions' request.
    */
   Response updateOptions(Request request) {
     // options
-    RequestDatum optionsDatum = request.getRequiredParameter(OPTIONS);
+    var params = new AnalysisUpdateOptionsParams.fromRequest(request);
+    AnalysisOptions newOptions = params.options;
     List<OptionUpdater> updaters = new List<OptionUpdater>();
-    optionsDatum.forEachMap((String optionName, RequestDatum optionDatum) {
-      if (optionName == ANALYZE_ANGULAR) {
-        bool optionValue = optionDatum.asBool();
-        updaters.add((AnalysisOptionsImpl options) {
-          options.analyzeAngular = optionValue;
-        });
-      } else if (optionName == ANALYZE_POLYMER) {
-        bool optionValue = optionDatum.asBool();
-        updaters.add((AnalysisOptionsImpl options) {
-          options.analyzePolymer = optionValue;
-        });
-      } else if (optionName == ENABLE_ASYNC) {
-        // TODO(brianwilkerson) Uncomment this when the option is supported.
-//        bool optionValue = optionDatum.asBool();
-//        updaters.add((AnalysisOptionsImpl options) {
-//          options.enableAsync = optionValue;
-//        });
-      } else if (optionName == ENABLE_DEFERRED_LOADING) {
-        bool optionValue = optionDatum.asBool();
-        updaters.add((AnalysisOptionsImpl options) {
-          options.enableDeferredLoading = optionValue;
-        });
-      } else if (optionName == ENABLE_ENUMS) {
-        // TODO(brianwilkerson) Uncomment this when the option is supported.
-//        bool optionValue = optionDatum.asBool();
-//        updaters.add((AnalysisOptionsImpl options) {
-//          options.enableEnums = optionValue;
-//        });
-      } else if (optionName == GENERATE_DART2JS_HINTS) {
-        bool optionValue = optionDatum.asBool();
-        updaters.add((AnalysisOptionsImpl options) {
-          options.dart2jsHint = optionValue;
-        });
-      } else if (optionName == GENERATE_HINTS) {
-        bool optionValue = optionDatum.asBool();
-        updaters.add((AnalysisOptionsImpl options) {
-          options.hint = optionValue;
-        });
-      } else {
-        throw new RequestFailure(
-            new Response.unknownOptionName(request, optionName));
-      }
-    });
+    // TODO(paulberry): analyzeAngular and analyzePolymer are not in the API.
+//    if (newOptions.analyzeAngular != null) {
+//      updaters.add((engine.AnalysisOptionsImpl options) {
+//        options.analyzeAngular = newOptions.analyzeAngular;
+//      });
+//    }
+//    if (newOptions.analyzePolymer != null) {
+//      updaters.add((engine.AnalysisOptionsImpl options) {
+//        options.analyzePolymer = newOptions.analyzePolymer;
+//      });
+//    }
+    if (newOptions.enableAsync != null) {
+      // TODO(brianwilkerson) Uncomment this when the option is supported.

[Brian Wilkerson, 2014/08/19 19:50:17]

The enableAsync and enableEnum options should be supported now. (Not that it
needs to be changed for this CL.)

[Paul Berry, 2014/08/19 19:58:06]

Ok.  I went ahead and uncommented the code.

+//      updaters.add((engine.AnalysisOptionsImpl options) {
+//        options.enableAsync = newOptions.enableAsync;
+//      });
+    }
+    if (newOptions.enableDeferredLoading != null) {
+      updaters.add((engine.AnalysisOptionsImpl options) {
+        options.enableDeferredLoading = newOptions.enableDeferredLoading;
+      });
+    }
+    if (newOptions.enableEnums != null) {
+      // TODO(brianwilkerson) Uncomment this when the option is supported.
+//      updaters.add((engine.AnalysisOptionsImpl options) {
+//        options.enableEnums = newOptions.enableEnums;
+//      });
+    }
+    if (newOptions.generateDart2jsHints != null) {
+      updaters.add((engine.AnalysisOptionsImpl options) {
+        options.dart2jsHint = newOptions.generateDart2jsHints;
+      });
+    }
+    if (newOptions.generateHints != null) {
+      updaters.add((engine.AnalysisOptionsImpl options) {
+        options.hint = newOptions.generateHints;
+      });
+    }
     server.updateOptions(updaters);
     return new Response(request.id);
   }
 }
 
 
 /**
  * A description of the change to the content of a file.
  */
 class ContentChange {
   /**
    * Type of content change.  'add' means that [content] contains the full
    * content of the file, and [changes] should be null.  'change' means that
    * [changes] contains changes to be applied to the file, and [content] should
    * be null.  'remove' means that the file should be read from the filesystem,
    * and both [content] and [changes] should be null.
    */
   String type;
 
   String content;
   List<Edit> changes;
 }