Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: pkg/analysis_server/test/domain_analysis_test.dart

Issue 492483002: Change analysis.updateOptions to use generated classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_analysis_test.dart
diff --git a/pkg/analysis_server/test/domain_analysis_test.dart b/pkg/analysis_server/test/domain_analysis_test.dart
index fa22e2984473d27012ca8a369ee50987282bd84c..fee5b590d11d33e37866e9903a4ee0a9e95ac7bc 100644
--- a/pkg/analysis_server/test/domain_analysis_test.dart
+++ b/pkg/analysis_server/test/domain_analysis_test.dart
@@ -15,7 +15,6 @@ import 'package:analysis_server/src/protocol2.dart' show AnalysisService,
import 'package:analysis_testing/mock_sdk.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
-import 'package:analyzer/src/generated/engine.dart';
import 'package:path/path.dart';
import 'package:unittest/unittest.dart';
@@ -143,24 +142,26 @@ main() {
'not-an-option': true
});
var response = handler.handleRequest(request);
- expect(response, isResponseFailure('0'));
- });
-
- test('valid', () {
- AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
- bool analyzeAngular = !options.analyzeAngular;
- bool enableDeferredLoading = options.enableDeferredLoading;
- var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
- request.setParameter(OPTIONS, {
- 'analyzeAngular': analyzeAngular,
- 'enableDeferredLoading': enableDeferredLoading,
- 'enableEnums': false
- });
- var response = handler.handleRequest(request);
+ // Invalid options should be silently ignored.
expect(response, isResponseSuccess('0'));
- expect(options.analyzeAngular, equals(analyzeAngular));
- expect(options.enableDeferredLoading, equals(enableDeferredLoading));
});
+
+ // TODO(paulberry): disabled because analyzeAngular is currently not in the API.
+// test('valid', () {
+// AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
+// bool analyzeAngular = !options.analyzeAngular;
+// bool enableDeferredLoading = options.enableDeferredLoading;
+// var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
+// request.setParameter(OPTIONS, {
+// 'analyzeAngular': analyzeAngular,
+// 'enableDeferredLoading': enableDeferredLoading,
+// 'enableEnums': false
+// });
+// var response = handler.handleRequest(request);
+// expect(response, isResponseSuccess('0'));
+// expect(options.analyzeAngular, equals(analyzeAngular));
+// expect(options.enableDeferredLoading, equals(enableDeferredLoading));
+// });
});
});
}

Powered by Google App Engine
This is Rietveld 408576698