Change analysis.updateOptions to use generated classes.

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/protocol2.dart' show AnalysisService,
     AnalysisError, AnalysisErrorsParams;
 import 'package:analysis_testing/mock_sdk.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
-import 'package:analyzer/src/generated/engine.dart';
 import 'package:path/path.dart';
 import 'package:unittest/unittest.dart';
 
 import 'analysis_abstract.dart';
 import 'mocks.dart';
 
 
 main() {
   groupSep = ' | ';
 
@@ skipping 107 matching lines @@
       });
     });
 
     group('updateOptions', () {
       test('invalid', () {
         var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
         request.setParameter(OPTIONS, {
           'not-an-option': true
         });
         var response = handler.handleRequest(request);
-        expect(response, isResponseFailure('0'));
+        // Invalid options should be silently ignored.
+        expect(response, isResponseSuccess('0'));
       });
 
-      test('valid', () {
-        AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
-        bool analyzeAngular = !options.analyzeAngular;
-        bool enableDeferredLoading = options.enableDeferredLoading;
-        var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
-        request.setParameter(OPTIONS, {
-          'analyzeAngular': analyzeAngular,
-          'enableDeferredLoading': enableDeferredLoading,
-          'enableEnums': false
-        });
-        var response = handler.handleRequest(request);
-        expect(response, isResponseSuccess('0'));
-        expect(options.analyzeAngular, equals(analyzeAngular));
-        expect(options.enableDeferredLoading, equals(enableDeferredLoading));
-      });
+      // TODO(paulberry): disabled because analyzeAngular is currently not in the API.
+//      test('valid', () {
+//        AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
+//        bool analyzeAngular = !options.analyzeAngular;
+//        bool enableDeferredLoading = options.enableDeferredLoading;
+//        var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
+//        request.setParameter(OPTIONS, {
+//          'analyzeAngular': analyzeAngular,
+//          'enableDeferredLoading': enableDeferredLoading,
+//          'enableEnums': false
+//        });
+//        var response = handler.handleRequest(request);
+//        expect(response, isResponseSuccess('0'));
+//        expect(options.analyzeAngular, equals(analyzeAngular));
+//        expect(options.enableDeferredLoading, equals(enableDeferredLoading));
+//      });
     });
   });
 }
 
 
 testUpdateContent() {
   test('bad type', () {
     AnalysisTestHelper helper = new AnalysisTestHelper();
     helper.createSingleFileProject('// empty');
     return helper.waitForOperationsFinished().then((_) {
@@ skipping 454 matching lines @@
     return waitForServerOperationsPerformed(server);
   }
 
   static String _getCodeString(code) {
     if (code is List<String>) {
       code = code.join('\n');
     }
     return code as String;
   }
 }