editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java - Issue 492483002: Change analysis.updateOptions to use generated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java

Issue 492483002: Change analysis.updateOptions to use generated classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java

index c8451280c3d80f329dd4be2c38a2afb7f6740afe..bf57107665968f0b082e1fff6ee8a32674d5aaae 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java

@@ -171,8 +171,7 @@ public interface AnalysisServer {

* Update the options controlling analysis based on the given set of options. Any options that are

* not included in the analysis options will not be changed. If there are options in the analysis

- * options that are not valid an error will be reported but the values of the valid options will

- * still be updated.

+ * options that are not valid, they will be silently ignored.

* @param options The options that are to be used to control analysis.

« no previous file with comments | « no previous file | pkg/analysis_server/doc/api.html » ('j') | pkg/analysis_server/lib/src/domain_analysis.dart » ('J')