Fix analysis server to only send SERVER_STATUS when subscribed to.

Fix analysis server to only send SERVER_STATUS when subscribed to.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39065

[Brian Wilkerson, 2014-08-09 15:33:16]

LGTM

https://codereview.chromium.org/453263002/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/integration_tests.dart (right):

https://codereview.chromium.org/453263002/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/integration_tests.dart:97: return
Future.wait(futures);
Out of curiosity, is there any performance penalty for waiting on a list with a
single item rather than returning the single item?

[Paul Berry, 2014-08-09 15:42:46]

https://codereview.chromium.org/453263002/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/integration_tests.dart (right):

https://codereview.chromium.org/453263002/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/integration_tests.dart:97: return
Future.wait(futures);
On 2014/08/09 15:33:16, Brian Wilkerson wrote:
> Out of curiosity, is there any performance penalty for waiting on a list with
a
> single item rather than returning the single item?

Looking at the implementation in sdk/lib/async/future.dart, there is some minor
additional bookkeeping (a list, a completer, and a few local variables are
used), but IMHO it should never be a large enough penalty to worry about.

[Paul Berry, 2014-08-09 16:36:48]

Committed patchset #1 manually as r39065 (presubmit successful).