Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Unified Diff: pkg/analysis_server/test/integration/server_domain_int_test.dart

Issue 453263002: Fix analysis server to only send SERVER_STATUS when subscribed to. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/server_domain_int_test.dart
diff --git a/pkg/analysis_server/test/integration/server_domain_int_test.dart b/pkg/analysis_server/test/integration/server_domain_int_test.dart
index 01490aed608cb71d0e0ffc4f1f8e7cb0e49a0ca4..4ff8bab8a61686f08c12b1547f700805ab02bc5c 100644
--- a/pkg/analysis_server/test/integration/server_domain_int_test.dart
+++ b/pkg/analysis_server/test/integration/server_domain_int_test.dart
@@ -32,8 +32,7 @@ class ServerDomainIntegrationTest extends AbstractAnalysisServerIntegrationTest
});
}
- fail_test_setSubscriptions() {
- // TODO(paulberry): fix the server so that it passes this test.
+ test_setSubscriptions() {
bool statusReceived = false;
Completer analysisBegun = new Completer();
server.onNotification(SERVER_STATUS).listen((_) {
@@ -50,7 +49,7 @@ class ServerDomainIntegrationTest extends AbstractAnalysisServerIntegrationTest
main() {
var x;
}''');
- standardAnalysisRoot();
+ standardAnalysisSetup(subscribeStatus: false);
// Analysis should begin, but no server.status notification should be
// received.
return analysisBegun.future.then((_) {
@@ -89,9 +88,6 @@ main() {
}
test_status() {
- // TODO(paulberry): spec says that server.status is not subscribed to by
- // default, but currently it's behaving as though it is.
-
// After we kick off analysis, we should get one server.status message with
// analyzing=true, and another server.status message after that with
// analyzing=false.
@@ -113,7 +109,7 @@ main() {
main() {
var x;
}''');
- standardAnalysisRoot();
+ standardAnalysisSetup();
expect(analysisBegun.isCompleted, isFalse);
expect(analysisFinished.isCompleted, isFalse);
return analysisBegun.future.then((_) {

Powered by Google App Engine
This is Rietveld 408576698