Fix analysis server to only send SERVER_STATUS when subscribed to.

pkg/analysis_server/test/integration/analysis_domain_int_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis.domain;
 
 import 'dart:async';
 
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:path/path.dart';
@@ skipping 19 matching lines @@
   num localVar = topLevelVar.length;
   topLevelVar.length = param;
   topLevelVar.add(localVar);
 }
 
 main() {
   func(35);
 }
 ''';
     writeFile(pathname, text);
-    standardAnalysisRoot();
+    standardAnalysisSetup();
 
     testHover(String target, int length, List<String> descriptionRegexps, String
         kind, List<String> staticTypeRegexps, {bool isCore: false, String docRegexp:
         null, bool isLiteral: false, List<String> parameterRegexps:
         null, propagatedType: null}) {
       int offset = text.indexOf(target);
       return sendAnalysisGetHover(pathname, offset).then((result) {
         expect(result['hovers'], hasLength(1));
         var info = result['hovers'][0];
         expect(info['offset'], equals(offset));
@@ skipping 80 matching lines @@
   }
 
   test_getHover_noInfo() {
     String pathname = sourcePath('test.dart');
     String text = r'''
 main() {
   // no code
 }
 ''';
     writeFile(pathname, text);
-    standardAnalysisRoot();
+    standardAnalysisSetup();
 
     // Note: analysis.getHover doesn't wait for analysis to complete--it simply
     // returns the latest results that are available at the time that the
     // request is made.  So wait for analysis to finish before testing anything.
     return analysisFinished.then((_) {
       return sendAnalysisGetHover(pathname, text.indexOf('no code')).then(
           (result) {
         expect(result['hovers'], hasLength(0));
       });
     });
   }
 
   test_getErrors_before_analysis() {
     return getErrorsTest(false);
   }
 
   test_getErrors_after_analysis() {
     return getErrorsTest(true);
   }
 
   Future getErrorsTest(bool afterAnalysis) {
     String pathname = sourcePath('test.dart');
     String text = r'''
 main() {
   var x // parse error: missing ';'
 }''';
     writeFile(pathname, text);
-    standardAnalysisRoot();
+    standardAnalysisSetup();
     Future finishTest() {
       return sendAnalysisGetErrors(pathname).then((result) {
         expect(result['errors'], equals(currentAnalysisErrors[pathname]));
       });
     }
     if (afterAnalysis) {
       return analysisFinished.then((_) => finishTest());
     } else {
       return finishTest();
     }
   }
 
   test_updateContent_content_only() {
     return updateContentTest(false);
   }
 
   test_updateContent_including_offset_and_lengths() {
     return updateContentTest(true);
   }
 
   Future updateContentTest(bool includeOffsetAndLengths) {
     String pathname = sourcePath('test.dart');
     String goodText = r'''
 main() {
   print("Hello, world!");
 }''';
     String badText = goodText.replaceAll(';', '');
     writeFile(pathname, badText);
-    standardAnalysisRoot();
+    standardAnalysisSetup();
     return analysisFinished.then((_) {
       // The contents on disk (badText) are missing a semicolon.
       expect(currentAnalysisErrors[pathname], isNot(isEmpty));
 
       if (includeOffsetAndLengths) {
         // Before we send a ChangeContentOverlay directive we need to send an
         // AddContentOverlay directive.  So send that with badText.
         return sendAnalysisUpdateContent({
           pathname: {
             'type': 'add',
@@ skipping 16 matching lines @@
           pathname: {
             'type': 'add',
             'content': goodText
           }
         });
       }
     }).then((result) => analysisFinished).then((_) {
       // There should be no errors now because the contents on disk have been
       // overriden with goodText.
       expect(currentAnalysisErrors[pathname], isEmpty);
-      // TODO(paulberry): passing "checkTypes: false" to work around the fact
-      // that isContentChange doesn't permit 'content' to be null.
       return sendAnalysisUpdateContent({
         pathname: {
           'type': 'remove'
         }
       });
     }).then((result) => analysisFinished).then((_) {
       // Now there should be errors again, because the contents on disk are no
       // longer overridden.
       expect(currentAnalysisErrors[pathname], isNot(isEmpty));
     });
   }
 }
 
 main() {
   runReflectiveTests(AnalysisDomainIntegrationTest);
 }