Fix analysis server to only send SERVER_STATUS when subscribed to.

pkg/analysis_server/test/integration/server_domain_int_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.server.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_testing/reflective_tests.dart';
@@ skipping 14 matching lines @@
       return new Future.delayed(new Duration(seconds: 1)).then((_) {
         sendServerGetVersion().then((_) {
           fail('Server still alive after server.shutdown');
         });
         // Give the server time to respond before terminating the test.
         return new Future.delayed(new Duration(seconds: 1));
       });
     });
   }
 
-  fail_test_setSubscriptions() {
-    // TODO(paulberry): fix the server so that it passes this test.
+  test_setSubscriptions() {
     bool statusReceived = false;
     Completer analysisBegun = new Completer();
     server.onNotification(SERVER_STATUS).listen((_) {
       statusReceived = true;
     });
     server.onNotification(ANALYSIS_ERRORS).listen((_) {
       if (!analysisBegun.isCompleted) {
         analysisBegun.complete();
       }
     });
     return sendServerSetSubscriptions([]).then((_) {
       String pathname = sourcePath('test.dart');
       writeFile(pathname, '''
 main() {
   var x;
 }''');
-      standardAnalysisRoot();
+      standardAnalysisSetup(subscribeStatus: false);
       // Analysis should begin, but no server.status notification should be
       // received.
       return analysisBegun.future.then((_) {
         expect(statusReceived, isFalse);
         return sendServerSetSubscriptions(['STATUS']).then((_) {
           // Tickle test.dart just in case analysis has already completed.
           writeFile(pathname, '''
 main() {
   var y;
 }''');
@@ skipping 18 matching lines @@
   test_connected() {
     expect(serverConnectedParams, isNull);
   }
 
   test_error() {
     // TODO(paulberry): how do we test the 'server.error' notification given
     // that this notification should only occur in the event of a server bug?
   }
 
   test_status() {
-    // TODO(paulberry): spec says that server.status is not subscribed to by
-    // default, but currently it's behaving as though it is.
-
     // After we kick off analysis, we should get one server.status message with
     // analyzing=true, and another server.status message after that with
     // analyzing=false.
     Completer analysisBegun = new Completer();
     Completer analysisFinished = new Completer();
     server.onNotification(SERVER_STATUS).listen((params) {
       expect(params, isServerStatusParams);
       if (params['analysis'] != null) {
         if (params['analysis']['analyzing']) {
           expect(analysisBegun.isCompleted, isFalse);
           analysisBegun.complete();
         } else {
           expect(analysisFinished.isCompleted, isFalse);
           analysisFinished.complete();
         }
       }
     });
     writeFile(sourcePath('test.dart'), '''
 main() {
   var x;
 }''');
-    standardAnalysisRoot();
+    standardAnalysisSetup();
     expect(analysisBegun.isCompleted, isFalse);
     expect(analysisFinished.isCompleted, isFalse);
     return analysisBegun.future.then((_) {
       expect(analysisFinished.isCompleted, isFalse);
       return analysisFinished.future;
     });
   }
 }
 
 main() {
   runReflectiveTests(ServerDomainIntegrationTest);
 }