Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: pkg/analysis_server/test/integration/analysis_domain_int_test.dart

Issue 453263002: Fix analysis server to only send SERVER_STATUS when subscribed to. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis_domain_int_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis_domain_int_test.dart b/pkg/analysis_server/test/integration/analysis_domain_int_test.dart
index 30fa12e2a9b6751b1f6c1b1960fa278d3096282c..1282a1b5e0722659c953bd900c3c86094ce5eb48 100644
--- a/pkg/analysis_server/test/integration/analysis_domain_int_test.dart
+++ b/pkg/analysis_server/test/integration/analysis_domain_int_test.dart
@@ -37,7 +37,7 @@ main() {
}
''';
writeFile(pathname, text);
- standardAnalysisRoot();
+ standardAnalysisSetup();
testHover(String target, int length, List<String> descriptionRegexps, String
kind, List<String> staticTypeRegexps, {bool isCore: false, String docRegexp:
@@ -138,7 +138,7 @@ main() {
}
''';
writeFile(pathname, text);
- standardAnalysisRoot();
+ standardAnalysisSetup();
// Note: analysis.getHover doesn't wait for analysis to complete--it simply
// returns the latest results that are available at the time that the
@@ -166,7 +166,7 @@ main() {
var x // parse error: missing ';'
}''';
writeFile(pathname, text);
- standardAnalysisRoot();
+ standardAnalysisSetup();
Future finishTest() {
return sendAnalysisGetErrors(pathname).then((result) {
expect(result['errors'], equals(currentAnalysisErrors[pathname]));
@@ -195,7 +195,7 @@ main() {
}''';
String badText = goodText.replaceAll(';', '');
writeFile(pathname, badText);
- standardAnalysisRoot();
+ standardAnalysisSetup();
return analysisFinished.then((_) {
// The contents on disk (badText) are missing a semicolon.
expect(currentAnalysisErrors[pathname], isNot(isEmpty));
@@ -232,8 +232,6 @@ main() {
// There should be no errors now because the contents on disk have been
// overriden with goodText.
expect(currentAnalysisErrors[pathname], isEmpty);
- // TODO(paulberry): passing "checkTypes: false" to work around the fact
- // that isContentChange doesn't permit 'content' to be null.
return sendAnalysisUpdateContent({
pathname: {
'type': 'remove'

Powered by Google App Engine
This is Rietveld 408576698