Send 'analysis.errors' notification only for files in analysis roots.

Send 'analysis.errors' notification only for files in analysis roots.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38944

[Brian Wilkerson, 2014-08-06 19:40:44]

LGTM

https://codereview.chromium.org/443213002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_directory_manager.dart (right):

https://codereview.chromium.org/443213002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:247: bool
isInAnalysisRoot(String path) {
This doesn't look like it's taking care of excluded files, but it isn't clear to
me that we're currently capturing that information. At the very least we should
add a TODO.

[scheglov, 2014-08-06 19:58:04]

https://codereview.chromium.org/443213002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_directory_manager.dart (right):

https://codereview.chromium.org/443213002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:247: bool
isInAnalysisRoot(String path) {
On 2014/08/06 19:40:43, Brian Wilkerson wrote:
> This doesn't look like it's taking care of excluded files, but it isn't clear
to
> me that we're currently capturing that information. At the very least we
should
> add a TODO.

Thanks, I was going to add TODO, but forgot.
Done.

[scheglov, 2014-08-06 19:58:08]

Committed patchset #1 manually as 38944 (presubmit successful).