Send 'analysis.errors' notification only for files in analysis roots.

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/error.dart';
@@ skipping 23 matching lines @@
   AnalysisDomainHandler handler;
 
   setUp(() {
     serverChannel = new MockServerChannel();
     resourceProvider = new MemoryResourceProvider();
     server = new AnalysisServer(serverChannel, resourceProvider,
         new MockPackageMapProvider(), null, new MockSdk());
     handler = new AnalysisDomainHandler(server);
   });
 
-  group('notification.errors', testNotificationErrors);
   group('updateContent', testUpdateContent);
   group('setSubscriptions', test_setSubscriptions);
 
   group('AnalysisDomainHandler', () {
     group('setAnalysisRoots', () {
       Request request;
 
       setUp(() {
         request = new Request('0', ANALYSIS_SET_ANALYSIS_ROOTS);
         request.setParameter(INCLUDED, []);
@@ skipping 86 matching lines @@
         var response = handler.handleRequest(request);
         expect(response, isResponseSuccess('0'));
         expect(options.analyzeAngular, equals(analyzeAngular));
         expect(options.enableDeferredLoading, equals(enableDeferredLoading));
       });
     });
   });
 }
 
 
-testNotificationErrors() {
-  AnalysisTestHelper helper;
-
-  setUp(() {
-    helper = new AnalysisTestHelper();
-  });
-
-  test('ParserError', () {
-    helper.createSingleFileProject('library lib');
-    return helper.waitForOperationsFinished().then((_) {
-      List<AnalysisError> errors = helper.getTestErrors();
-      expect(errors, hasLength(1));
-      AnalysisError error = errors[0];
-      expect(error.location.file, '/project/bin/test.dart');
-      expect(error.location.offset, isPositive);
-      expect(error.location.length, isNonNegative);
-      expect(error.severity, 'ERROR');
-      expect(error.type, 'SYNTACTIC_ERROR');
-      expect(error.message, isNotNull);
-    });
-  });
-
-  test('StaticWarning', () {
-    helper.createSingleFileProject(['main() {', '  print(unknown);', '}']);
-    return helper.waitForOperationsFinished().then((_) {
-      List<AnalysisError> errors = helper.getTestErrors();
-      expect(errors, hasLength(1));
-      AnalysisError error = errors[0];
-      expect(error.severity, 'WARNING');
-      expect(error.type, 'STATIC_WARNING');
-    });
-  });
-}
-
-
 testUpdateContent() {
   test('full content', () {
     AnalysisTestHelper helper = new AnalysisTestHelper();
     helper.createSingleFileProject('// empty');
     return helper.waitForOperationsFinished().then((_) {
       // no errors initially
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, isEmpty);
       // update code
       helper.sendContentChange({
@@ skipping 107 matching lines @@
         var highlights = helper.getHighlights(helper.testFile);
         expect(highlights, isNot(isEmpty));
       });
     });
   });
 
   test('after analysis, no such file', () {
     AnalysisTestHelper helper = new AnalysisTestHelper();
     helper.createSingleFileProject('int V = 42;');
     return helper.waitForOperationsFinished().then((_) {
-      String noFile = '/no-such.file.dart';
-      helper.addAnalysisSubscriptionErrors(noFile);
+      String noFile = '/no-such-file.dart';
+      helper.addAnalysisSubscriptionHighlights(noFile);
       return helper.waitForOperationsFinished().then((_) {
-        var errors = helper.getErrors(noFile);
-        expect(errors, isEmpty);
+        var highlights = helper.getHighlights(noFile);
+        expect(highlights, isEmpty);
       });
     });
   });
 }
 
 
 int _getSafeInt(Map<String, Object> json, String key, int defaultValue) {
   Object value = json[key];
   if (value is int) {
     return value;
@@ skipping 124 matching lines @@
       files = <String>[];
       analysisSubscriptions[service.name] = files;
     }
     files.add(file);
     // set subscriptions
     Request request = new Request('0', ANALYSIS_SET_SUBSCRIPTIONS);
     request.setParameter(SUBSCRIPTIONS, analysisSubscriptions);
     handleSuccessfulRequest(request);
   }
 
-  void addAnalysisSubscriptionErrors(String file) {
-    addAnalysisSubscription(AnalysisService.ERRORS, file);
-  }
-
   void addAnalysisSubscriptionHighlights(String file) {
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, file);
   }
 
   void addAnalysisSubscriptionNavigation(String file) {
     addAnalysisSubscription(AnalysisService.NAVIGATION, file);
   }
 
   /**
    * Creates an empty project `/project`.
@@ skipping 129 matching lines @@
     return waitForServerOperationsPerformed(server);
   }
 
   static String _getCodeString(code) {
     if (code is List<String>) {
       code = code.join('\n');
     }
     return code as String;
   }
 }