Send 'analysis.errors' notification only for files in analysis roots.

pkg/analysis_server/lib/src/context_directory_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 223 matching lines @@
     }
     // Emacs creates dummy links to track the fact that a file is open for
     // editing and has unsaved changes (e.g. having unsaved changes to
     // 'foo.dart' causes a link '.#foo.dart' to be created, which points to the
     // non-existent file 'username@hostname.pid'.  To avoid these dummy links
     // causing the analyzer to thrash, just ignore links to non-existent files.
     return file.exists;
   }
 
   /**
+   * Returns `true` if the given absolute [path] is in one of the current
+   * root folders and is not excluded.
+   */
+  bool isInAnalysisRoot(String path) {

[Brian Wilkerson, 2014/08/06 19:40:43]

This doesn't look like it's taking care of excluded files, but it isn't clear to
me that we're currently capturing that information. At the very least we should
add a TODO.

[scheglov, 2014/08/06 19:58:04]

Thanks, I was going to add TODO, but forgot.
Done.

+    for (Folder root in _currentDirectoryInfo.keys) {
+      if (path.startsWith(root.path)) {
+        return true;
+      }
+    }
+    return false;
+  }
+
+  /**
    * Called when a new context needs to be created.
    */
   void addContext(Folder folder, Map<String, List<Folder>> packageMap);
 
   /**
    * Called when the set of files associated with a context have changed (or
    * some of those files have been modified).  [changeSet] is the set of
    * changes that need to be applied to the context.
    */
   void applyChangesToContext(Folder contextFolder, ChangeSet changeSet);
 
   /**
    * Remove the context associated with the given [folder].
    */
   void removeContext(Folder folder);
 
   /**
    * Called when the package map for a context has changed.
    */
   void updateContextPackageMap(Folder contextFolder,
                                Map<String, List<Folder>> packageMap);
 }