Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 443213002: Send 'analysis.errors' notification only for files in analysis roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/analysis_server/lib/src/context_directory_manager.dart ('K') | « pkg/analysis_server/lib/src/context_directory_manager.dart ('k') | pkg/analysis_server/test/analysis/notification_errors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 914d5d52bb70785ad90a84db7546f71137a33216..d8b10ec446fa115413cd95f588b9c03b759943ee 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -158,8 +158,7 @@ class PerformAnalysisOperation extends ServerOperation {
sendAnalysisNotificationOverrides(server, file, dartUnit);
}
}
- // TODO(scheglov) use default subscriptions
- if (!source.isInSystemLibrary) {
+ if (server.shouldSendErrorsNotificationFor(file)) {
sendAnalysisNotificationErrors(
server,
file,
« pkg/analysis_server/lib/src/context_directory_manager.dart ('K') | « pkg/analysis_server/lib/src/context_directory_manager.dart ('k') | pkg/analysis_server/test/analysis/notification_errors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698