Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 443213002: Send 'analysis.errors' notification only for files in analysis roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library operation.analysis; 5 library operation.analysis;
6 6
7 import 'package:analysis_server/src/analysis_server.dart'; 7 import 'package:analysis_server/src/analysis_server.dart';
8 import 'package:analysis_server/src/computer/computer_highlights.dart'; 8 import 'package:analysis_server/src/computer/computer_highlights.dart';
9 import 'package:analysis_server/src/computer/computer_navigation.dart'; 9 import 'package:analysis_server/src/computer/computer_navigation.dart';
10 import 'package:analysis_server/src/computer/computer_occurrences.dart'; 10 import 'package:analysis_server/src/computer/computer_occurrences.dart';
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 if (server.hasAnalysisSubscription(AnalysisService.OCCURRENCES, file)) { 151 if (server.hasAnalysisSubscription(AnalysisService.OCCURRENCES, file)) {
152 sendAnalysisNotificationOccurrences(server, file, dartUnit); 152 sendAnalysisNotificationOccurrences(server, file, dartUnit);
153 } 153 }
154 if (server.hasAnalysisSubscription(AnalysisService.OUTLINE, file)) { 154 if (server.hasAnalysisSubscription(AnalysisService.OUTLINE, file)) {
155 sendAnalysisNotificationOutline(server, context, source, dartUnit); 155 sendAnalysisNotificationOutline(server, context, source, dartUnit);
156 } 156 }
157 if (server.hasAnalysisSubscription(AnalysisService.OVERRIDES, file)) { 157 if (server.hasAnalysisSubscription(AnalysisService.OVERRIDES, file)) {
158 sendAnalysisNotificationOverrides(server, file, dartUnit); 158 sendAnalysisNotificationOverrides(server, file, dartUnit);
159 } 159 }
160 } 160 }
161 // TODO(scheglov) use default subscriptions 161 if (server.shouldSendErrorsNotificationFor(file)) {
162 if (!source.isInSystemLibrary) {
163 sendAnalysisNotificationErrors( 162 sendAnalysisNotificationErrors(
164 server, 163 server,
165 file, 164 file,
166 notice.lineInfo, 165 notice.lineInfo,
167 notice.errors); 166 notice.errors);
168 } 167 }
169 } 168 }
170 } 169 }
171 170
172 void updateIndex(Index index, List<ChangeNotice> notices) { 171 void updateIndex(Index index, List<ChangeNotice> notices) {
(...skipping 11 matching lines...) Expand all
184 // HTML 183 // HTML
185 { 184 {
186 HtmlUnit htmlUnit = notice.htmlUnit; 185 HtmlUnit htmlUnit = notice.htmlUnit;
187 if (htmlUnit != null) { 186 if (htmlUnit != null) {
188 index.indexHtmlUnit(context, htmlUnit); 187 index.indexHtmlUnit(context, htmlUnit);
189 } 188 }
190 } 189 }
191 } 190 }
192 } 191 }
193 } 192 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698