Improve script display in the observatory.

Improve script display in the observatory.

- <script-inset> now supports scrolling

- <script-inset> can now highlight and scroll to the current line

- 'args' (#pos=55) are now passed to Panes (and some ObservatoryElements).

- <script-view> now scrolls to the current line.

- coverage data (red/green) is now shown as the background of the line #.
  Saves space.  Reworked the colors a bit to make black text visible.

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38092

[Cutch, 2014-07-09 15:49:23]

Very nice change!

lgtm with some comments.

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
(right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart:18:
@published ObservableMap args;
I wonder if this is the best way to pass args to elements. Would it be nicer if
each element had a reference to its pane and could grab the args from the pane?

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/script_inset.dart:46: var observer
= new MutationObserver(_onMutation);
Do we have to do anything with the mutation observer in detached?

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/script_view.dart (right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/script_view.dart:28: int
parseInt(String value) {
These polymer expression utility functions usually hang off of
ObservatoryElement.

[turnidge, 2014-07-09 17:36:32]

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/script_inset.dart:46: var observer
= new MutationObserver(_onMutation);
On 2014/07/09 15:49:22, Cutch wrote:
> Do we have to do anything with the mutation observer in detached?

Yes, there is a disconnect method I should call.  Done.

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/script_view.dart (right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/script_view.dart:28: int
parseInt(String value) {
On 2014/07/09 15:49:22, Cutch wrote:
> These polymer expression utility functions usually hang off of
> ObservatoryElement.

Done.

[turnidge, 2014-07-09 17:37:08]

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
(right):

https://codereview.chromium.org/378113002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart:18:
@published ObservableMap args;
On 2014/07/09 15:49:22, Cutch wrote:
> I wonder if this is the best way to pass args to elements. Would it be nicer
if
> each element had a reference to its pane and could grab the args from the
pane?

Reworked.

[turnidge, 2014-07-09 17:37:59]

Committed patchset #4 manually as r38092 (presubmit successful).