Improve script display in the observatory.

runtime/bin/vmservice/client/lib/src/app/application.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of app;
 
 /// The observatory application. Instances of this are created and owned
 /// by the observatory_application custom element.
 class ObservatoryApplication extends Observable {
   static ObservatoryApplication app;
-  final _paneRegistry = new List<Pane>();
-  Pane _currentPane;
+  final _pageRegistry = new List<Page>();
+  @observable Page currentPage;
   @observable final LocationManager locationManager;
   VM _vm;
   VM get vm => _vm;
   set vm(VM vm) {
     if (_vm == vm) {
       // Do nothing.
       return;
     }
     if (_vm != null) {
       // Disconnect from current VM.
@@ skipping 12 matching lines @@
   @observable Isolate isolate;
   @reflectable final ObservatoryApplicationElement rootElement;
 
   @reflectable ServiceObject lastErrorOrException;
   @observable ObservableList<ServiceEvent> notifications =
       new ObservableList<ServiceEvent>();
 
   void _initOnce(bool chromium) {
     assert(app == null);
     app = this;
-    _registerPanes();
+    _registerPages();
     locationManager._init(this);
   }
 
   void removePauseEvents(Isolate isolate) {
     bool isPauseEvent(var event) {
       return (event.eventType == 'IsolateInterrupted' ||
               event.eventType == 'BreakpointReached' ||
               event.eventType == 'ExceptionThrown');
     }
 
@@ skipping 28 matching lines @@
         notifications.add(event);
         break;
 
       default:
         // Ignore unrecognized events.
         Logger.root.severe('Unrecognized event type: ${event.eventType}');
         break;
     }
   }
 
-  void _registerPanes() {
-    // Register ClassTreePane.
-    _paneRegistry.add(new ClassTreePane(this));
-    _paneRegistry.add(new VMConnectPane(this));
-    _paneRegistry.add(new ErrorViewPane(this));
-    // Note that ServiceObjectPane must be the last entry in the list as it is
+  void _registerPages() {
+    // Register ClassTreePage.
+    _pageRegistry.add(new ClassTreePage(this));
+    _pageRegistry.add(new VMConnectPage(this));
+    _pageRegistry.add(new ErrorViewPage(this));
+    // Note that ServiceObjectPage must be the last entry in the list as it is
     // the catch all.
-    _paneRegistry.add(new ServiceObjectPane(this));
+    _pageRegistry.add(new ServiceObjectPage(this));
   }
 
   void _onError(ServiceError error) {
     lastErrorOrException = error;
     _visit('error/', null);
   }
 
   void _onException(ServiceException exception) {
     lastErrorOrException = exception;
     if (exception.kind == 'NetworkException') {
-      // Got a network exception, visit the vm-connect pane.
+      // Got a network exception, visit the vm-connect page.
       locationManager.go(locationManager.makeLink('/vm-connect/'));
     } else {
       _visit('error/', null);
     }
   }
 
   void _visit(String url, String args) {
-    // TODO(johnmccutchan): Pass [args] to pane.
-    for (var i = 0; i < _paneRegistry.length; i++) {
-      var pane = _paneRegistry[i];
-      if (pane.canVisit(url)) {
-        _installPane(pane);
-        pane.visit(url);
+    var argsMap;
+    if (args == null) {
+      argsMap = {};
+    } else {
+      argsMap = Uri.splitQueryString(args);
+    }
+    for (var i = 0; i < _pageRegistry.length; i++) {
+      var page = _pageRegistry[i];
+      if (page.canVisit(url)) {
+        _installPage(page);
+        page.visit(url, argsMap);
         return;
       }
     }
     throw new FallThroughError();
   }
 
-  /// Set the Observatory application pane.
-  void _installPane(Pane pane) {
-    assert(pane != null);
-    if (_currentPane == pane) {
+  /// Set the Observatory application page.
+  void _installPage(Page page) {
+    assert(page != null);
+    if (currentPage == page) {
       // Already isntalled.
       return;
     }
-    if (_currentPane != null) {
-      Logger.root.info('Uninstalling pane: $_currentPane');
-      _currentPane.onUninstall();
+    if (currentPage != null) {
+      Logger.root.info('Uninstalling page: $currentPage');
+      currentPage.onUninstall();
       // Clear children.
       rootElement.children.clear();
     }
-    Logger.root.info('Installing pane: $pane');
+    Logger.root.info('Installing page: $page');
     try {
-      pane.onInstall();
+      page.onInstall();
     } catch (e) {
-      Logger.root.severe('Failed to install pane: $e');
+      Logger.root.severe('Failed to install page: $e');
     }
-    // Add new pane.
-    rootElement.children.add(pane.element);
-    // Remember pane.
-    _currentPane = pane;
+    // Add new page.
+    rootElement.children.add(page.element);
+    // Remember page.
+    currentPage = page;
   }
 
   ObservatoryApplication.devtools(this.rootElement) :
       locationManager = new HashLocationManager(),
       targets = null {
     vm = new PostMessageVM();
     _initOnce(true);
   }
 
   ObservatoryApplication(this.rootElement) :
@@ skipping 11 matching lines @@
 
   _vmDisconnected(VM vm) {
     if (this.vm != vm) {
       // This disconnect event occured *after* a new VM was installed.
       return;
     }
     this.vm = null;
     locationManager.go(locationManager.makeLink('/vm-connect/'));
   }
 }