Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.dart

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library script_view_element; 5 library script_view_element;
6 6
7 import 'observatory_element.dart'; 7 import 'observatory_element.dart';
8 import 'package:observatory/elements.dart'; 8 import 'package:observatory/elements.dart';
9 import 'package:observatory/service.dart'; 9 import 'package:observatory/service.dart';
10 import 'package:polymer/polymer.dart'; 10 import 'package:polymer/polymer.dart';
11 11
12 /// Displays an Script response. 12 /// Displays an Script response.
13 @CustomTag('script-view') 13 @CustomTag('script-view')
14 class ScriptViewElement extends ObservatoryElement { 14 class ScriptViewElement extends ObservatoryElement {
15 @published Script script; 15 @published Script script;
16 16
17 ScriptViewElement.created() : super.created(); 17 ScriptViewElement.created() : super.created();
18 18
19 @override 19 @override
20 void attached() { 20 void attached() {
21 super.attached(); 21 super.attached();
22 if (script == null) { 22 if (script == null) {
23 return; 23 return;
24 } 24 }
25 script.load(); 25 script.load();
26 } 26 }
27 27
28 int parseInt(String value) {
Cutch 2014/07/09 15:49:22 These polymer expression utility functions usually
turnidge 2014/07/09 17:36:32 Done.
29 return int.parse(value);
30 }
31
28 void refresh(var done) { 32 void refresh(var done) {
29 script.reload().whenComplete(done); 33 script.reload().whenComplete(done);
30 } 34 }
31 35
32 void refreshCoverage(var done) { 36 void refreshCoverage(var done) {
33 script.refreshCoverage().whenComplete(done); 37 script.refreshCoverage().whenComplete(done);
34 } 38 }
35 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698