runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart - Issue 378113002: Improve script display in the observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/isolate_view.html ('k') | runtime/bin/vmservice/client/lib/src/elements/script_inset.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

index b53e7cf2b7221f51f120a1a92b724a8986820d46..74feff79aeeb5e368d12aac717cdf68f2bd4ab2e 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

@@ -15,6 +15,8 @@ class ObservatoryElement extends PolymerElement {

ObservatoryElement.created() : super.created();

ObservatoryApplication get app => ObservatoryApplication.app;

+ Page get page => app.currentPage;

+ ObservableMap get args => page.args;

@override

void attached() {

@@ -108,6 +110,8 @@ class ObservatoryElement extends PolymerElement {

return "${shortFile}:${frame['line']}";

}

+ int parseInt(String value) => int.parse(value);

bool isNull(String type) {

return type == 'Null';

}