runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html - Issue 378113002: Improve script display in the observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_inset.html ('k') | runtime/bin/vmservice/client/lib/app.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html

diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html

index a99bb896cc5f1eaa8b5656d73ffd3c4224528214..bd54c72958b3bd1d4507f3961977414856681be8 100644

--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html

+++ b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html

@@ -16,10 +16,20 @@

<nav-control></nav-control>

</nav-bar>

- <script-inset id="scriptInset" script="{{ script }}" pos="{{ script.firstTokenPos }}" endPos="{{ script.lastTokenPos }}">

- <h1>script {{ script.name }}</h1>

- </script-inset>

+ <template if="{{ args['pos'] == null }}">

+ <script-inset id="scriptInset" script="{{ script }}">

+ <h1>script {{ script.name }}</h1>

+ </script-inset>

+ </template>

+ <template if="{{ args['pos'] != null }}">

+ <script-inset id="scriptInset" script="{{ script }}"

+ currentPos="{{ args['pos'] | parseInt }}">

+ <h1>script {{ script.name }}</h1>

+ </script-inset>

+ </template>

</template>

</polymer-element>

-<script type="application/dart" src="script_view.dart"></script>

+<script type="application/dart" src="script_view.dart"></script>