Issue 274043003: Adds debugger patching to arm64.

Issue 274043003: Adds debugger patching to arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds debugger patching to arm64. Also other small fixes. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36003

Patch Set 5 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -98 lines)			Patch
M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1	4 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View		3 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View		6 chunks	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/code_patcher_arm64.cc	View		2 chunks	+33 lines, -6 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/debugger_arm64.cc	View	1 2 3	1 chunk	+63 lines, -8 lines	0 comments	Download
M	runtime/vm/debugger_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 2	3 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/instructions_arm64.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_arm64.cc	View		4 chunks	+40 lines, -3 lines	0 comments	Download
M	runtime/vm/instructions_arm64_test.cc	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		3 chunks	+9 lines, -10 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/parser_test.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	2 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/274043003/diff/40001/runtime/vm/debugger_arm64.cc File runtime/vm/debugger_arm64.cc (right): https://codereview.chromium.org/274043003/diff/40001/runtime/vm/debugger_arm64.cc#newcode22 runtime/vm/debugger_arm64.cc:22: *reinterpret_cast<uword*>(receiver_addr)); Strange indentation https://codereview.chromium.org/274043003/diff/40001/runtime/vm/debugger_arm64.cc#newcode32 runtime/vm/debugger_arm64.cc:32: *reinterpret_cast<uword*>(closure_addr)); ditto https://codereview.chromium.org/274043003/diff/40001/runtime/vm/intermediate_language_arm.cc ...

6 years, 7 months ago (2014-05-09 22:17:44 UTC) #2

zra

Thanks! https://codereview.chromium.org/274043003/diff/40001/runtime/vm/debugger_arm64.cc File runtime/vm/debugger_arm64.cc (right): https://codereview.chromium.org/274043003/diff/40001/runtime/vm/debugger_arm64.cc#newcode22 runtime/vm/debugger_arm64.cc:22: *reinterpret_cast<uword*>(receiver_addr)); On 2014/05/09 22:17:44, regis wrote: > Strange ...

6 years, 7 months ago (2014-05-09 22:49:24 UTC) #3

zra

6 years, 7 months ago (2014-05-09 23:20:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r36003 (presubmit successful).

Expand Messages | Collapse Messages