Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 274043003: Adds debugger patching to arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_test.cc ('k') | runtime/vm/instructions_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm64.cc (revision 35975)
+++ runtime/vm/flow_graph_compiler_arm64.cc (working copy)
@@ -902,7 +902,7 @@
Isolate::kNoDeoptId, kNumArgsChecked));
__ LoadObject(R5, ic_data, PP);
__ LeaveDartFrame(); // The arguments are still on the stack.
- __ BranchFixed(&StubCode::CallNoSuchMethodFunctionLabel());
+ __ BranchPatchable(&StubCode::CallNoSuchMethodFunctionLabel());
// The noSuchMethod call may return to the caller, but not here.
__ hlt(0);
} else if (check_correct_named_args) {
@@ -1077,7 +1077,7 @@
Isolate::kNoDeoptId, kNumArgsChecked));
__ LoadObject(R5, ic_data, PP);
__ LeaveDartFrame(); // The arguments are still on the stack.
- __ BranchFixed(&StubCode::CallNoSuchMethodFunctionLabel());
+ __ BranchPatchable(&StubCode::CallNoSuchMethodFunctionLabel());
// The noSuchMethod call may return to the caller, but not here.
__ hlt(0);
} else {
@@ -1110,14 +1110,12 @@
AddCurrentDescriptor(PcDescriptors::kPatchCode,
Isolate::kNoDeoptId,
0); // No token position.
- __ BranchFixed(&StubCode::FixCallersTargetLabel());
+ __ BranchPatchable(&StubCode::FixCallersTargetLabel());
AddCurrentDescriptor(PcDescriptors::kLazyDeoptJump,
Isolate::kNoDeoptId,
0); // No token position.
- // TODO(zra): Can I use a normal BranchPatchable here? Probably have to change
- // the CodePatcher.
- __ BranchFixed(&StubCode::DeoptimizeLazyLabel());
+ __ BranchPatchable(&StubCode::DeoptimizeLazyLabel());
}
« no previous file with comments | « runtime/vm/debugger_test.cc ('k') | runtime/vm/instructions_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698