runtime/vm/simulator_arm64.cc - Issue 274043003: Adds debugger patching to arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm64.cc

Issue 274043003: Adds debugger patching to arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/simulator_arm64.cc

===================================================================

--- runtime/vm/simulator_arm64.cc (revision 35975)

+++ runtime/vm/simulator_arm64.cc (working copy)

@@ -2210,8 +2210,8 @@

result = vn_val - vm_val;

break;

default:

- // Unknown(instr);

- break;

+ UnimplementedInstruction(instr);

+ return;

}

set_vregisterd(vd, bit_cast<int64_t, double>(result));

@@ -2221,12 +2221,12 @@

void Simulator::DecodeFPCompare(Instr* instr) {

const VRegister vn = instr->VnField();

const VRegister vm = instr->VmField();

- const double vn_val = get_vregisterd(vn);

+ const double vn_val = bit_cast<double, int64_t>(get_vregisterd(vn));

double vm_val;

if ((instr->Bit(22) == 1) && (instr->Bits(3, 2) == 0)) {

// Format(instr, "fcmpd 'vn, 'vm");

- vm_val = get_vregisterd(vm);

+ vm_val = bit_cast<double, int64_t>(get_vregisterd(vm));

} else if ((instr->Bit(22) == 1) && (instr->Bits(3, 2) == 1)) {

if (instr->VmField() == V0) {

// Format(instr, "fcmpd 'vn, #0.0");

« no previous file with comments | « runtime/vm/parser_test.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »