Issue 25931003: Make List.shuffle take an optional Random object to use.

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 2 months ago

Reviewers:
bakster, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make List.shuffle take an optional Random object to use. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28305

Patch Set 2 : Address comment. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -178 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/java_core.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/third_party/html5lib/lib/src/list_proxy.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/unmodifiable_collection/lib/unmodifiable_collection.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/lib/array.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_collection_dev/iterable.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_collection_dev/list.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/interceptors.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_array.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/collection/list.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/core/core.dart	View		5 chunks	+9 lines, -8 lines	0 comments	Download
M	sdk/lib/core/list.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		16 chunks	+21 lines, -21 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		11 chunks	+131 lines, -122 lines	0 comments	Download
M	sdk/lib/typed_data/typed_data.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/shuffle_test.dart	View	1	3 chunks	+34 lines, -0 lines	0 comments	Download
M	third_party/pkg/js/lib/js_wrapping.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/pkg/js/lib/src/wrapping/js/array_to_list_adapter.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/src/ImmutableListMixin.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bakster

DBC https://codereview.chromium.org/25931003/diff/1/tests/corelib/shuffle_test.dart File tests/corelib/shuffle_test.dart (right): https://codereview.chromium.org/25931003/diff/1/tests/corelib/shuffle_test.dart#newcode132 tests/corelib/shuffle_test.dart:132: } Please refactor: int _next() => _values[index++ % ...

7 years, 2 months ago (2013-10-04 11:19:34 UTC) #2

Lasse Reichstein Nielsen

7 years, 2 months ago (2013-10-07 12:07:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28305 (presubmit successful).

Expand Messages | Collapse Messages