pkg/third_party/html5lib/lib/src/list_proxy.dart - Issue 25931003: Make List.shuffle take an optional Random object to use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/third_party/html5lib/lib/src/list_proxy.dart

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer_experimental/lib/src/generated/java_core.dart ('k') | pkg/unmodifiable_collection/lib/unmodifiable_collection.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/third_party/html5lib/lib/src/list_proxy.dart

diff --git a/pkg/third_party/html5lib/lib/src/list_proxy.dart b/pkg/third_party/html5lib/lib/src/list_proxy.dart

index 786e39373a99b82b7f42600bfc847a5ae4375faf..d779043cdf6b9786773117ac50f9814916ded4ba 100644

--- a/pkg/third_party/html5lib/lib/src/list_proxy.dart

+++ b/pkg/third_party/html5lib/lib/src/list_proxy.dart

@@ -5,6 +5,7 @@

library list_proxy;

import 'dart:collection';

+import 'dart:math' show Random;

// TOOD(jmesserly): this needs to be removed, but fixing NodeList is tricky.

class ListProxy<E> extends IterableBase<E> implements List<E> {

@@ -51,7 +52,7 @@ class ListProxy<E> extends IterableBase<E> implements List<E> {

void addLast(E value) { add(value); }

void addAll(Iterable<E> collection) { _list.addAll(collection); }

void sort([int compare(E a, E b)]) { _list.sort(compare); }

- void shuffle() { _list.shuffle(); }

+ void shuffle([Random random]) { _list.shuffle(random); }

int indexOf(E element, [int start = 0]) => _list.indexOf(element, start);

int lastIndexOf(E element, [int start]) => _list.lastIndexOf(element, start);