Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 12b2267c6cb12f91ac76bd76e78bf4d838b9b6eb..36b5c2f405bb8311528b465b9f9212b65fbbb799 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -2785,7 +2785,7 @@ class CssRule extends Interceptor native "CSSRule" {
@DomName('CSSStyleDeclaration')
- class CssStyleDeclaration extends Interceptor with
+ class CssStyleDeclaration extends Interceptor with
CssStyleDeclarationBase native "CSSStyleDeclaration,MSStyleCSSProperties,CSS2Properties" {
factory CssStyleDeclaration() => new CssStyleDeclaration.css('');
@@ -2794,7 +2794,7 @@ class CssRule extends Interceptor native "CSSRule" {
style.cssText = css;
return style;
}
-
+
String getPropertyValue(String propertyName) {
var propValue = _getPropertyValue(propertyName);
return propValue != null ? propValue : '';
@@ -2814,7 +2814,7 @@ class CssRule extends Interceptor native "CSSRule" {
}
} catch (e) {}
}
-
+
/**
* Checks to see if CSS Transitions are supported.
*/
@@ -2892,7 +2892,7 @@ class _CssStyleDeclarationSet extends Object with CssStyleDeclarationBase {
}
abstract class CssStyleDeclarationBase {
- String getPropertyValue(String propertyName);
+ String getPropertyValue(String propertyName);
void setProperty(String propertyName, String value, [String priority]);
// TODO(jacobr): generate this list of properties using the existing script.
@@ -3752,8 +3752,8 @@ abstract class CssStyleDeclarationBase {
}
/** Gets the value of "box-sizing" */
- String get boxSizing => Device.isFirefox ?
- getPropertyValue('${Device.cssPrefix}box-sizing') :
+ String get boxSizing => Device.isFirefox ?
+ getPropertyValue('${Device.cssPrefix}box-sizing') :
getPropertyValue('box-sizing');
/** Sets the value of "box-sizing" */
@@ -8166,7 +8166,7 @@ class _ChildrenElementList extends ListBase<Element> {
throw new UnsupportedError('Cannot sort element lists');
}
- void shuffle() {
+ void shuffle([Random random]) {
throw new UnsupportedError('Cannot shuffle element lists');
}
@@ -8615,7 +8615,7 @@ class _FrozenElementList<T extends Element> extends ListBase<T> implements Eleme
throw new UnsupportedError('Cannot sort list');
}
- void shuffle() {
+ void shuffle([Random random]) {
throw new UnsupportedError('Cannot shuffle list');
}
@@ -13148,8 +13148,8 @@ class HttpRequest extends XmlHttpRequestEventTarget native "XMLHttpRequest" {
/**
* Makes a server POST request with the specified data encoded as form data.
*
- * This is roughly the POST equivalent of getString. This method is similar
- * to sending a FormData object with broader browser support but limited to
+ * This is roughly the POST equivalent of getString. This method is similar
+ * to sending a FormData object with broader browser support but limited to
* String values.
*
* See also:
@@ -13184,7 +13184,7 @@ class HttpRequest extends XmlHttpRequestEventTarget native "XMLHttpRequest" {
* Creates and sends a URL request for the specified [url].
*
* By default `request` will perform an HTTP GET request, but a different
- * method (`POST`, `PUT`, `DELETE`, etc) can be used by specifying the
+ * method (`POST`, `PUT`, `DELETE`, etc) can be used by specifying the
* [method] parameter.
*
* The Future is completed when the response is available.
@@ -14783,15 +14783,15 @@ class InputMethodContext extends Interceptor native "InputMethodContext" {
@DomName('KeyboardEvent')
class KeyboardEvent extends UIEvent native "KeyboardEvent" {
- /**
- * Programmatically create a KeyboardEvent.
+ /**
+ * Programmatically create a KeyboardEvent.
*
* Due to browser differences, keyCode, charCode, or keyIdentifier values
* cannot be specified in this base level constructor. This constructor
* enables the user to programmatically create and dispatch a [KeyboardEvent],
* but it will not contain any particular key content. For programmatically
* creating keyboard events with specific key value contents, see the custom
- * Event [KeyEvent].
+ * Event [KeyEvent].
*/
factory KeyboardEvent(String type,
{Window view, bool canBubble: true, bool cancelable: true,
@@ -17925,7 +17925,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
throw new UnsupportedError("Cannot sort Node list");
}
- void shuffle() {
+ void shuffle([Random random]) {
throw new UnsupportedError("Cannot shuffle Node list");
}
@@ -18804,7 +18804,7 @@ class OptGroupElement extends HtmlElement native "HTMLOptGroupElement" {
@DomName('HTMLOptionElement')
class OptionElement extends HtmlElement native "HTMLOptionElement" {
- factory OptionElement({String data, String value, bool defaultSelected,
+ factory OptionElement({String data, String value, bool defaultSelected,
bool selected}) {
return new OptionElement._(data, value, defaultSelected, selected);
}
@@ -24459,10 +24459,10 @@ class Url extends Interceptor native "URL" {
static String createObjectUrlFromSource(MediaSource source) =>
JS('String', '(self.URL || self.webkitURL).createObjectURL(#)', source);
-
+
static String createObjectUrlFromStream(MediaStream stream) =>
JS('String', '(self.URL || self.webkitURL).createObjectURL(#)', stream);
-
+
static String createObjectUrlFromBlob(Blob blob) =>
JS('String', '(self.URL || self.webkitURL).createObjectURL(#)', blob);
@@ -29790,7 +29790,7 @@ abstract class ImmutableListMixin<E> implements List<E> {
throw new UnsupportedError("Cannot sort immutable List.");
}
- void shuffle() {
+ void shuffle([Random random]) {
throw new UnsupportedError("Cannot shuffle immutable List.");
}
@@ -31295,7 +31295,7 @@ abstract class _MicrotaskScheduler {
* Scheduler which uses window.postMessage to schedule events.
*/
class _PostMessageScheduler extends _MicrotaskScheduler {
- const _MICROTASK_MESSAGE = "DART-MICROTASK";
+ final _MICROTASK_MESSAGE = "DART-MICROTASK";
_PostMessageScheduler(_MicrotaskCallback callback): super(callback) {
// Messages from other windows do not cause a security risk as
@@ -32453,7 +32453,7 @@ class FixedSizeListIterator<T> implements Iterator<T> {
final int _length; // Cache array length for faster access.
int _position;
T _current;
-
+
FixedSizeListIterator(List<T> array)
: _array = array,
_position = -1,
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698