sdk/lib/_collection_dev/iterable.dart - Issue 25931003: Make List.shuffle take an optional Random object to use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_collection_dev/iterable.dart

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_collection_dev/iterable.dart

diff --git a/sdk/lib/_collection_dev/iterable.dart b/sdk/lib/_collection_dev/iterable.dart

index 5001fe38fe20cefba1d83a18e521d7404e5a38c4..3cc913baa37eae41ef30921970ba3b3805939ef4 100644

--- a/sdk/lib/_collection_dev/iterable.dart

+++ b/sdk/lib/_collection_dev/iterable.dart

@@ -958,8 +958,8 @@ class IterableMixinWorkaround {

Sort.sort(list, compare);

}

- static void shuffleList(List list) {

- Random random = new Random();

+ static void shuffleList(List list, Random random) {

+ if (random == null) random = new Random();

int length = list.length;

while (length > 1) {

int pos = random.nextInt(length);

« no previous file with comments | « runtime/lib/typed_data.dart ('k') | sdk/lib/_collection_dev/list.dart » ('j') | no next file with comments »