sdk/lib/_internal/lib/js_array.dart - Issue 25931003: Make List.shuffle take an optional Random object to use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_array.dart

Issue 25931003: Make List.shuffle take an optional Random object to use. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/js_array.dart

diff --git a/sdk/lib/_internal/lib/js_array.dart b/sdk/lib/_internal/lib/js_array.dart

index b6ec0cbd4453d92e8170a17b0863b1781dcfc8de..32c0c8cbc67f760fda7f80c2aa8d5b2fb28ffea0 100644

--- a/sdk/lib/_internal/lib/js_array.dart

+++ b/sdk/lib/_internal/lib/js_array.dart

@@ -243,8 +243,8 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

IterableMixinWorkaround.sortList(this, compare);

}

- void shuffle() {

- IterableMixinWorkaround.shuffleList(this);

+ void shuffle([Random random]) {

+ IterableMixinWorkaround.shuffleList(this, random);

}

int indexOf(Object element, [int start = 0]) {

« no previous file with comments | « sdk/lib/_internal/lib/interceptors.dart ('k') | sdk/lib/collection/list.dart » ('j') | no next file with comments »