Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 25081002: Remove openglui embedder code (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org, shailentuli
Visibility:
Public.

Description

Remove openglui embedder code This code has rotted. We should eventually fix and land outside the Dart repo. I've verified that > ./tools/build.py -m release --os=android still builds (with target_os=android in .gclient). R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=28018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7635 lines) Patch
M runtime/dart-runtime.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
D runtime/embedders/openglui/android/android_graphics_handler.h View 1 chunk +0 lines, -27 lines 0 comments Download
D runtime/embedders/openglui/android/android_graphics_handler.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D runtime/embedders/openglui/android/android_input_handler.h View 1 chunk +0 lines, -36 lines 0 comments Download
D runtime/embedders/openglui/android/android_log.h View 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/embedders/openglui/android/android_resource.h View 1 chunk +0 lines, -67 lines 0 comments Download
D runtime/embedders/openglui/android/android_sound_handler.h View 1 chunk +0 lines, -55 lines 0 comments Download
D runtime/embedders/openglui/android/android_sound_handler.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D runtime/embedders/openglui/android/eventloop.h View 1 chunk +0 lines, -51 lines 0 comments Download
D runtime/embedders/openglui/android/eventloop.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D runtime/embedders/openglui/android/main.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D runtime/embedders/openglui/android/support_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D runtime/embedders/openglui/build_skia.sh View 1 chunk +0 lines, -112 lines 0 comments Download
D runtime/embedders/openglui/common/canvas_context.h View 1 chunk +0 lines, -324 lines 0 comments Download
D runtime/embedders/openglui/common/canvas_context.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D runtime/embedders/openglui/common/canvas_state.h View 1 chunk +0 lines, -312 lines 0 comments Download
D runtime/embedders/openglui/common/canvas_state.cc View 1 chunk +0 lines, -411 lines 0 comments Download
D runtime/embedders/openglui/common/context.h View 1 chunk +0 lines, -23 lines 0 comments Download
D runtime/embedders/openglui/common/dart_host.h View 1 chunk +0 lines, -47 lines 0 comments Download
D runtime/embedders/openglui/common/dart_host.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D runtime/embedders/openglui/common/events.h View 1 chunk +0 lines, -39 lines 0 comments Download
D runtime/embedders/openglui/common/extension.h View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/embedders/openglui/common/extension.cc View 1 chunk +0 lines, -1737 lines 0 comments Download
D runtime/embedders/openglui/common/gl.dart View 1 chunk +0 lines, -1211 lines 0 comments Download
D runtime/embedders/openglui/common/graphics_handler.h View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/embedders/openglui/common/graphics_handler.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D runtime/embedders/openglui/common/image_cache.h View 1 chunk +0 lines, -58 lines 0 comments Download
D runtime/embedders/openglui/common/image_cache.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D runtime/embedders/openglui/common/input_handler.h View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/embedders/openglui/common/input_handler.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D runtime/embedders/openglui/common/isized.h View 1 chunk +0 lines, -21 lines 0 comments Download
D runtime/embedders/openglui/common/lifecycle_handler.h View 1 chunk +0 lines, -26 lines 0 comments Download
D runtime/embedders/openglui/common/log.h View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/embedders/openglui/common/opengl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D runtime/embedders/openglui/common/resource.h View 1 chunk +0 lines, -59 lines 0 comments Download
D runtime/embedders/openglui/common/sample.h View 1 chunk +0 lines, -63 lines 0 comments Download
D runtime/embedders/openglui/common/sound_handler.h View 1 chunk +0 lines, -66 lines 0 comments Download
D runtime/embedders/openglui/common/sound_handler.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D runtime/embedders/openglui/common/support.h View 1 chunk +0 lines, -37 lines 0 comments Download
D runtime/embedders/openglui/common/timer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D runtime/embedders/openglui/common/timer.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D runtime/embedders/openglui/common/types.h View 1 chunk +0 lines, -24 lines 0 comments Download
D runtime/embedders/openglui/common/vm_glue.h View 1 chunk +0 lines, -78 lines 0 comments Download
D runtime/embedders/openglui/common/vm_glue.cc View 1 chunk +0 lines, -398 lines 0 comments Download
D runtime/embedders/openglui/emulator/emulator_embedder.h View 1 chunk +0 lines, -14 lines 0 comments Download
D runtime/embedders/openglui/emulator/emulator_embedder.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D runtime/embedders/openglui/emulator/emulator_graphics_handler.h View 1 chunk +0 lines, -19 lines 0 comments Download
D runtime/embedders/openglui/emulator/emulator_graphics_handler.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D runtime/embedders/openglui/emulator/emulator_resource.h View 1 chunk +0 lines, -64 lines 0 comments Download
D runtime/embedders/openglui/openglui_embedder.gypi View 1 chunk +0 lines, -310 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 2 months ago (2013-09-27 16:11:42 UTC) #1
zra
lgtm
7 years, 2 months ago (2013-09-27 16:38:14 UTC) #2
vsm
7 years, 2 months ago (2013-09-27 17:01:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698